Skip to site navigation (Press enter)

[webkit-changes] [243949] tags/Safari-608.1.15

alancoon Fri, 05 Apr 2019 15:09:21 -0700

Title: [243949] tags/Safari-608.1.15

Revision: 243949
Author: alanc...@apple.com
Date: 2019-04-05 15:08:22 -0700 (Fri, 05 Apr 2019)

Log Message

Revert r243839. rdar://problem/49654398


Modified Paths

tags/Safari-608.1.15/LayoutTests/ChangeLog
tags/Safari-608.1.15/LayoutTests/js/regexp-unicode-expected.txt
tags/Safari-608.1.15/LayoutTests/js/script-tests/regexp-unicode.js
tags/Safari-608.1.15/Source/_javascript_Core/ChangeLog
tags/Safari-608.1.15/Source/_javascript_Core/yarr/YarrJIT.cpp

Diff

Modified: tags/Safari-608.1.15/LayoutTests/ChangeLog (243948 => 243949)


--- tags/Safari-608.1.15/LayoutTests/ChangeLog	2019-04-05 21:58:32 UTC (rev 243948)
+++ tags/Safari-608.1.15/LayoutTests/ChangeLog	2019-04-05 22:08:22 UTC (rev 243949)
@@ -1,3 +1,7 @@
+2019-04-05  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Revert r243839. rdar://problem/49654398
+
 2019-04-03  Timothy Hatcher  <timo...@apple.com>
 
         Update AutoFill field icons to be SVG instead of PNG images.

Modified: tags/Safari-608.1.15/LayoutTests/js/regexp-unicode-expected.txt (243948 => 243949)


--- tags/Safari-608.1.15/LayoutTests/js/regexp-unicode-expected.txt	2019-04-05 21:58:32 UTC (rev 243948)
+++ tags/Safari-608.1.15/LayoutTests/js/regexp-unicode-expected.txt	2019-04-05 22:08:22 UTC (rev 243949)
@@ -148,9 +148,6 @@
 PASS "𐌑𐌐𐌑".match(/[𐌁𐌑]*?a|[𐌐𐌑]*?./iu)[0] is "𐌑"
 PASS "𐌑𐌐𐌑".match(/[𐌁𐌑]+a|[𐌐𐌑]+./iu)[0] is "𐌑𐌐𐌑"
 PASS "𐌑𐌐𐌑".match(/[𐌁𐌑]+?a|[𐌐𐌑]+?./iu)[0] is "𐌑𐌐"
-PASS "𐌑𐌐𐌑".match(/[𐌁𐌑]+?a$|[𐌐𐌑]+?.$/iu)[0] is "𐌑𐌐𐌑"
-PASS "𐌑𐌐𐌑".match(/[𐌁𐌑x]+a|[𐌐𐌑x]+./iu)[0] is "𐌑𐌐𐌑"
-PASS "𐌑𐌐𐌑".match(/[𐌁𐌑x]+?a|[𐌐𐌑x]+?./iu)[0] is "𐌑𐌐"
 PASS "C83|НАЧАТЬ".match(re8)[0] is "C83|НАЧАТЬ"
 PASS "This.Is.16.Chars|НАЧАТЬ".match(re8)[0] is "This.Is.16.Chars|НАЧАТЬ"
 PASS "Testing\nሴ 1 2 3".match(/^[က-𐃿] 1 2 3/um)[0] is "ሴ 1 2 3"

Modified: tags/Safari-608.1.15/LayoutTests/js/script-tests/regexp-unicode.js (243948 => 243949)


--- tags/Safari-608.1.15/LayoutTests/js/script-tests/regexp-unicode.js	2019-04-05 21:58:32 UTC (rev 243948)
+++ tags/Safari-608.1.15/LayoutTests/js/script-tests/regexp-unicode.js	2019-04-05 22:08:22 UTC (rev 243949)
@@ -205,9 +205,6 @@
 shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}]*?a|[\u{10310}\u{10311}]*?./iu)[0]', '"\u{10311}"');
 shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}]+a|[\u{10310}\u{10311}]+./iu)[0]', '"\u{10311}\u{10310}\u{10311}"');
 shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}]+?a|[\u{10310}\u{10311}]+?./iu)[0]', '"\u{10311}\u{10310}"');
-shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}]+?a$|[\u{10310}\u{10311}]+?.$/iu)[0]', '"\u{10311}\u{10310}\u{10311}"');
-shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}x]+a|[\u{10310}\u{10311}x]+./iu)[0]', '"\u{10311}\u{10310}\u{10311}"');
-shouldBe('"\u{10311}\u{10310}\u{10311}".match(/[\u{10301}\u{10311}x]+?a|[\u{10310}\u{10311}x]+?./iu)[0]', '"\u{10311}\u{10310}"');
 
 var re8 = new  RegExp("^([0-9a-z\.]{3,16})\\|\u{041d}\u{0410}\u{0427}\u{0410}\u{0422}\u{042c}", "ui");
 shouldBe('"C83|\u{041d}\u{0410}\u{0427}\u{0410}\u{0422}\u{042c}".match(re8)[0]', '"C83|\u{041d}\u{0410}\u{0427}\u{0410}\u{0422}\u{042c}"');

Modified: tags/Safari-608.1.15/Source/_javascript_Core/ChangeLog (243948 => 243949)


--- tags/Safari-608.1.15/Source/_javascript_Core/ChangeLog	2019-04-05 21:58:32 UTC (rev 243948)
+++ tags/Safari-608.1.15/Source/_javascript_Core/ChangeLog	2019-04-05 22:08:22 UTC (rev 243949)
@@ -1,3 +1,7 @@
+2019-04-05  Kocsen Chung  <kocsen_ch...@apple.com>
+
+        Revert r243839. rdar://problem/49654398
+
 2019-04-03  Yusuke Suzuki  <ysuz...@apple.com>
 
         Unreviewed, rolling in r243843 with the build fix

Modified: tags/Safari-608.1.15/Source/_javascript_Core/yarr/YarrJIT.cpp (243948 => 243949)


--- tags/Safari-608.1.15/Source/_javascript_Core/yarr/YarrJIT.cpp	2019-04-05 21:58:32 UTC (rev 243948)
+++ tags/Safari-608.1.15/Source/_javascript_Core/yarr/YarrJIT.cpp	2019-04-05 22:08:22 UTC (rev 243949)
@@ -1849,13 +1849,7 @@
 
         JumpList failures;
         Label loop(this);
-#ifdef JIT_UNICODE_EXPRESSIONS
-        if (term->characterClass->hasOneCharacterSize() && !term->invert() && term->characterClass->hasNonBMPCharacters()) {
-            move(TrustedImm32(1), character);
-            failures.append(checkNotEnoughInput(character));
-        } else
-#endif
-            failures.append(atEndOfInput());
+        failures.append(atEndOfInput());
 
         if (term->invert()) {
             readCharacter(m_checkedOffset - term->inputPosition, character);
@@ -1962,13 +1956,11 @@
 
         m_backtrackingState.link(this);
 
-#ifdef JIT_UNICODE_EXPRESSIONS
         if (m_decodeSurrogatePairs) {
             if (!term->characterClass->hasOneCharacterSize() || term->invert())
                 loadFromFrame(term->frameLocation + BackTrackInfoCharacterClass::beginIndex(), index);
             loadFromFrame(term->frameLocation + BackTrackInfoCharacterClass::matchAmountIndex(), countRegister);
         }
-#endif
 
         nonGreedyFailures.append(atEndOfInput());
         nonGreedyFailures.append(branch32(Equal, countRegister, Imm32(term->quantityMaxCount.unsafeGet())));

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes