Title: [243951] trunk/Source/WebKit
- Revision
- 243951
- Author
- achristen...@apple.com
- Date
- 2019-04-05 16:06:46 -0700 (Fri, 05 Apr 2019)
Log Message
Undeprecate WKNavigationData
https://bugs.webkit.org/show_bug.cgi?id=196559
<rdar://44927425>
Reviewed by Geoff Garen.
* UIProcess/API/Cocoa/WKNavigationData.h:
It is used to communicate information from FrameLoaderClient::updateGlobalHistory() to the application.
This use in WKBrowsingContextHistoryDelegate is definitely still deprecated, but its use in
WKHistoryDelegatePrivate does not have an adequate replacement yet, so it must remain undeprecated SPI.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243950 => 243951)
--- trunk/Source/WebKit/ChangeLog 2019-04-05 22:08:26 UTC (rev 243950)
+++ trunk/Source/WebKit/ChangeLog 2019-04-05 23:06:46 UTC (rev 243951)
@@ -1,3 +1,16 @@
+2019-04-05 Alex Christensen <achristen...@webkit.org>
+
+ Undeprecate WKNavigationData
+ https://bugs.webkit.org/show_bug.cgi?id=196559
+ <rdar://44927425>
+
+ Reviewed by Geoff Garen.
+
+ * UIProcess/API/Cocoa/WKNavigationData.h:
+ It is used to communicate information from FrameLoaderClient::updateGlobalHistory() to the application.
+ This use in WKBrowsingContextHistoryDelegate is definitely still deprecated, but its use in
+ WKHistoryDelegatePrivate does not have an adequate replacement yet, so it must remain undeprecated SPI.
+
2019-04-05 Sihui Liu <sihui_...@apple.com>
[iOS] Web process gets suspended while holding locked database files
Modified: trunk/Source/WebKit/Shared/Cocoa/APIObject.mm (243950 => 243951)
--- trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2019-04-05 22:08:26 UTC (rev 243950)
+++ trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2019-04-05 23:06:46 UTC (rev 243951)
@@ -256,9 +256,7 @@
break;
case Type::NavigationData:
- ALLOW_DEPRECATED_DECLARATIONS_BEGIN
wrapper = [WKNavigationData alloc];
- ALLOW_DEPRECATED_DECLARATIONS_END
break;
case Type::NavigationResponse:
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.h (243950 => 243951)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.h 2019-04-05 22:08:26 UTC (rev 243950)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.h 2019-04-05 23:06:46 UTC (rev 243951)
@@ -31,7 +31,7 @@
#import <Foundation/Foundation.h>
-WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKNavigation", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))
+WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
@interface WKNavigationData : NSObject
@property (readonly) NSString *title;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm (243950 => 243951)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm 2019-04-05 22:08:26 UTC (rev 243950)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm 2019-04-05 23:06:46 UTC (rev 243951)
@@ -30,9 +30,7 @@
#import <WebCore/ResourceRequest.h>
#import <WebCore/ResourceResponse.h>
-IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKNavigationData {
-IGNORE_WARNINGS_END
API::ObjectStorage<API::NavigationData> _data;
}
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDataInternal.h (243950 => 243951)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDataInternal.h 2019-04-05 22:08:26 UTC (rev 243950)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDataInternal.h 2019-04-05 23:06:46 UTC (rev 243951)
@@ -31,9 +31,7 @@
namespace WebKit {
template<> struct WrapperTraits<API::NavigationData> {
- ALLOW_DEPRECATED_DECLARATIONS_BEGIN
using WrapperClass = WKNavigationData;
- ALLOW_DEPRECATED_DECLARATIONS_END
};
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
