Title: [244259] trunk/Source/WebCore
- Revision
- 244259
- Author
- [email protected]
- Date
- 2019-04-15 04:49:12 -0700 (Mon, 15 Apr 2019)
Log Message
Ensure iOS layout traits are used for media controls in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196812
<rdar://problem/47460637>
Unreviewed. Speculative fix for test regressions on open-source bots.
* Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.get layoutTraits):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244258 => 244259)
--- trunk/Source/WebCore/ChangeLog 2019-04-15 07:43:45 UTC (rev 244258)
+++ trunk/Source/WebCore/ChangeLog 2019-04-15 11:49:12 UTC (rev 244259)
@@ -1,3 +1,14 @@
+2019-04-15 Antoine Quint <[email protected]>
+
+ Ensure iOS layout traits are used for media controls in modern compatibility mode
+ https://bugs.webkit.org/show_bug.cgi?id=196812
+ <rdar://problem/47460637>
+
+ Unreviewed. Speculative fix for test regressions on open-source bots.
+
+ * Modules/modern-media-controls/media/media-controller.js:
+ (MediaController.prototype.get layoutTraits):
+
2019-04-11 Antoine Quint <[email protected]>
Ensure iOS layout traits are used for media controls in modern compatibility mode
Modified: trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js (244258 => 244259)
--- trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2019-04-15 07:43:45 UTC (rev 244258)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2019-04-15 11:49:12 UTC (rev 244259)
@@ -99,7 +99,8 @@
if (this.host && this.host.compactMode)
return LayoutTraits.Compact;
- let traits = GestureRecognizer.SupportsTouches ? LayoutTraits.iOS : LayoutTraits.macOS;
+ // The window.navigator.platform !== "MacIntel" is strictly used for the test infrastructure since touch events are off for open-source bots.
+ let traits = GestureRecognizer.SupportsTouches || window.navigator.platform !== "MacIntel" ? LayoutTraits.iOS : LayoutTraits.macOS;
if (this.isFullscreen)
return traits | LayoutTraits.Fullscreen;
return traits;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes