Title: [244274] trunk/Source/WebInspectorUI
- Revision
- 244274
- Author
- [email protected]
- Date
- 2019-04-15 11:34:51 -0700 (Mon, 15 Apr 2019)
Log Message
Web Inspector: Debugger: deleting a special breakpoint should disable it
https://bugs.webkit.org/show_bug.cgi?id=196737
<rdar://problem/49740680>
Reviewed by Timothy Hatcher.
* UserInterface/Views/BreakpointTreeElement.js:
(WI.BreakpointTreeElement.prototype.ondelete):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (244273 => 244274)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 18:27:06 UTC (rev 244273)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 18:34:51 UTC (rev 244274)
@@ -1,5 +1,16 @@
2019-04-15 Devin Rousso <[email protected]>
+ Web Inspector: Debugger: deleting a special breakpoint should disable it
+ https://bugs.webkit.org/show_bug.cgi?id=196737
+ <rdar://problem/49740680>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/BreakpointTreeElement.js:
+ (WI.BreakpointTreeElement.prototype.ondelete):
+
+2019-04-15 Devin Rousso <[email protected]>
+
Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.selectedTreeElement.reveal')
https://bugs.webkit.org/show_bug.cgi?id=196804
<rdar://problem/49800708>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js (244273 => 244274)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js 2019-04-15 18:27:06 UTC (rev 244273)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js 2019-04-15 18:34:51 UTC (rev 244274)
@@ -77,8 +77,13 @@
ondelete()
{
- if (!WI.debuggerManager.isBreakpointRemovable(this._breakpoint))
+ if (!WI.debuggerManager.isBreakpointRemovable(this._breakpoint)) {
+ if (this._breakpoint.disabled)
+ InspectorFrontendHost.beep();
+ else
+ this._breakpoint.disabled = true;
return true;
+ }
// We set this flag so that TreeOutlines that will remove this
// BreakpointTreeElement will know whether it was deleted from
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
