Modified: trunk/LayoutTests/ChangeLog (244279 => 244280)
--- trunk/LayoutTests/ChangeLog 2019-04-15 19:17:14 UTC (rev 244279)
+++ trunk/LayoutTests/ChangeLog 2019-04-15 19:46:34 UTC (rev 244280)
@@ -1,3 +1,14 @@
+2019-04-15 Devin Rousso <[email protected]>
+
+ REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=194437
+ <rdar://problem/48008005>
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
+ * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
+
2019-04-15 Said Abou-Hallawa <[email protected]>
ASSERT fires when removing a disallowed clone from the shadow tree without reseting its corresponding element
Modified: trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt (244279 => 244280)
--- trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt 2019-04-15 19:17:14 UTC (rev 244279)
+++ trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt 2019-04-15 19:46:34 UTC (rev 244280)
@@ -3,13 +3,13 @@
== Running test suite: Page.overrideSetting
-- Running test case: Page.overrideSetting.ICECandidateFilteringEnabled
-PASS: created offer
-PASS: Should not be able to establish a connection when filtering ice candidates.
Overriding ICECandidateFilteringEnabled to false...
+Creating data channel...
PASS: created offer
PASS: received ICE candidate.
PASS: Should be able to establish a connection when filtering ice candidates.
Removing ICECandidateFilteringEnabled override...
+Creating data channel...
PASS: created offer
PASS: Should not be able to establish a connection when filtering ice candidates.
Modified: trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html (244279 => 244280)
--- trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html 2019-04-15 19:17:14 UTC (rev 244279)
+++ trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html 2019-04-15 19:46:34 UTC (rev 244280)
@@ -12,7 +12,7 @@
let dc = null;
- let pc = new RTCPeerConnection();
+ let pc = new RTCPeerConnection;
pc._onicecandidate_ = (event) => {
if (event.candidate) {
if (!receivedCandidate)
@@ -21,16 +21,14 @@
return;
}
+ TestPage.dispatchEventToFrontend("DataChannel", {success: !!receivedCandidate});
+
delete pc.onicecandidate;
pc.close();
dc.close();
-
- if (receivedCandidate) {
- TestPage.dispatchEventToFrontend("DataChannel", {success: true});
- } else
- TestPage.dispatchEventToFrontend("DataChannel", {success: false});
};
+ TestPage.addResult("Creating data channel...");
dc = pc.createDataChannel("sendDataChannel");
pc.createOffer()
@@ -45,6 +43,8 @@
function test()
{
+ InspectorTest.debug();
+
let suite = InspectorTest.createAsyncSuite("Page.overrideSetting");
suite.addTestCase({
@@ -51,12 +51,6 @@
name: "Page.overrideSetting.ICECandidateFilteringEnabled",
description: "Test that changing whether ice candidate filtering is enabled has an effect.",
async test() {
- let [defaultResult] = await Promise.all([
- InspectorTest.awaitEvent("DataChannel"),
- InspectorTest.evaluateInPage(`createDataChannel()`),
- ]);
- InspectorTest.expectFalse(defaultResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
-
InspectorTest.log("Overriding ICECandidateFilteringEnabled to false...");
await PageAgent.overrideSetting(PageAgent.Setting.ICECandidateFilteringEnabled, false);
@@ -64,7 +58,7 @@
InspectorTest.awaitEvent("DataChannel"),
InspectorTest.evaluateInPage(`createDataChannel()`),
])
- InspectorTest.expectFalse(defaultResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
+ InspectorTest.expectThat(overriddenResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
InspectorTest.log("Removing ICECandidateFilteringEnabled override...");
await PageAgent.overrideSetting(PageAgent.Setting.ICECandidateFilteringEnabled);
@@ -73,7 +67,7 @@
InspectorTest.awaitEvent("DataChannel"),
InspectorTest.evaluateInPage(`createDataChannel()`),
])
- InspectorTest.expectFalse(defaultResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
+ InspectorTest.expectFalse(originalResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
},
});
