Title: [244351] trunk/Source/WebInspectorUI
Revision
244351
Author
[email protected]
Date
2019-04-16 12:37:27 -0700 (Tue, 16 Apr 2019)

Log Message

Web Inspector: remove unused WI.DOMTreeDataGrid
https://bugs.webkit.org/show_bug.cgi?id=196958
<rdar://problem/49931383>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/DOMTreeDataGrid.css: Removed.
* UserInterface/Views/DOMTreeDataGrid.js: Removed.
* UserInterface/Views/DOMTreeDataGridNode.js: Removed.
* UserInterface/Main.html:

Modified Paths

Removed Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (244350 => 244351)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-04-16 19:02:23 UTC (rev 244350)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-04-16 19:37:27 UTC (rev 244351)
@@ -1,5 +1,18 @@
 2019-04-16  Devin Rousso  <[email protected]>
 
+        Web Inspector: remove unused WI.DOMTreeDataGrid
+        https://bugs.webkit.org/show_bug.cgi?id=196958
+        <rdar://problem/49931383>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DOMTreeDataGrid.css: Removed.
+        * UserInterface/Views/DOMTreeDataGrid.js: Removed.
+        * UserInterface/Views/DOMTreeDataGridNode.js: Removed.
+        * UserInterface/Main.html:
+
+2019-04-16  Devin Rousso  <[email protected]>
+
         Web Inspector: Storage: values truncated in Local/Session table
         https://bugs.webkit.org/show_bug.cgi?id=178318
         <rdar://problem/34998581>

Modified: trunk/Source/WebInspectorUI/UserInterface/Main.html (244350 => 244351)


--- trunk/Source/WebInspectorUI/UserInterface/Main.html	2019-04-16 19:02:23 UTC (rev 244350)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.html	2019-04-16 19:37:27 UTC (rev 244351)
@@ -83,7 +83,6 @@
     <link rel="stylesheet" href=""
     <link rel="stylesheet" href=""
     <link rel="stylesheet" href=""
-    <link rel="stylesheet" href=""
     <link rel="stylesheet" href=""
     <link rel="stylesheet" href=""
     <link rel="stylesheet" href=""
@@ -641,8 +640,6 @@
     <script src=""
     <script src=""
     <script src=""
-    <script src=""
-    <script src=""
     <script src=""
     <script src=""
     <script src=""

Deleted: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css (244350 => 244351)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css	2019-04-16 19:02:23 UTC (rev 244350)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css	2019-04-16 19:37:27 UTC (rev 244351)
@@ -1,35 +0,0 @@
-/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-.dom-tree-data-grid .data-grid {
-    border-right: none;
-    border-left: none;
-    border-bottom: none;
-}
-
-.dom-tree-data-grid .name-column .icon {
-    /* FIXME: There can be multiple types of DOM nodes that we might need to support in the future. */
-    content: url(../Images/DOMElement.svg);
-}

Deleted: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js (244350 => 244351)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js	2019-04-16 19:02:23 UTC (rev 244350)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js	2019-04-16 19:37:27 UTC (rev 244351)
@@ -1,62 +0,0 @@
-/*
- * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
- * Copyright (C) 2015 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-WI.DOMTreeDataGrid = class DOMTreeDataGrid extends WI.DataGrid
-{
-    constructor()
-    {
-        super({
-            name: {title: WI.UIString("Node"), sortable: false, icon: true}
-        });
-
-        this._previousHoveredElement = null;
-
-        this.inline = true;
-
-        this.element.classList.add("dom-tree-data-grid");
-
-        this.element.addEventListener("mousemove", this._onmousemove.bind(this), false);
-        this.element.addEventListener("mouseout", this._onmouseout.bind(this), false);
-    }
-
-    // Private
-
-    _onmousemove(event)
-    {
-        var gridNode = this.dataGridNodeFromNode(event.target);
-        if (!gridNode || this._previousHoveredElement === gridNode.domNode)
-            return;
-        this._previousHoveredElement = gridNode.domNode;
-        WI.domManager.highlightDOMNode(gridNode.domNode.id);
-    }
-
-    _onmouseout(event) {
-        if (!this._previousHoveredElement)
-            return;
-        WI.domManager.hideDOMNodeHighlight();
-        this._previousHoveredElement = null;
-    }
-};

Deleted: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js (244350 => 244351)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js	2019-04-16 19:02:23 UTC (rev 244350)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js	2019-04-16 19:37:27 UTC (rev 244351)
@@ -1,69 +0,0 @@
-/*
- * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
- * Copyright (C) 2015 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-WI.DOMTreeDataGridNode = class DOMTreeDataGridNode extends WI.DataGridNode
-{
-    constructor(domNode)
-    {
-        super();
-
-        this._domNode = domNode;
-    }
-
-    get domNode()
-    {
-        return this._domNode;
-    }
-
-    // DataGridNode Overrides.
-
-    createCellContent(columnIdentifier, cell)
-    {
-        if (columnIdentifier !== "name")
-            return super.createCellContent(columnIdentifier, cell);
-
-        return this._createNameCellDocumentFragment();
-    }
-
-    // Private
-
-    _createNameCellDocumentFragment()
-    {
-        let fragment = document.createDocumentFragment();
-        let mainTitle = this._domNode.displayName;
-        fragment.append(mainTitle);
-
-        let goToButton = fragment.appendChild(WI.createGoToArrowButton());
-        goToButton.addEventListener("click", this._goToArrowWasClicked.bind(this), false);
-
-        return fragment;
-    }
-
-    _goToArrowWasClicked()
-    {
-        WI.showMainFrameDOMTree(this._domNode, {ignoreSearchTab: true});
-    }
-};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to