Title: [244490] trunk/Source/WebCore
- Revision
- 244490
- Author
- jer.no...@apple.com
- Date
- 2019-04-20 16:46:25 -0700 (Sat, 20 Apr 2019)
Log Message
REGRESSION(r243958): Unnecessary deactivation of AudioSession (PLT Regression)
https://bugs.webkit.org/show_bug.cgi?id=197123
<rdar://problem/49783264>
Reviewed by Per Arne Vollan.
Only set m_becameActive if we actually activated the AudioSession before starting playback. This
avoids unnecessarily deactivating the AudioSession in processWillSuspend().
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244489 => 244490)
--- trunk/Source/WebCore/ChangeLog 2019-04-20 19:16:22 UTC (rev 244489)
+++ trunk/Source/WebCore/ChangeLog 2019-04-20 23:46:25 UTC (rev 244490)
@@ -1,3 +1,17 @@
+2019-04-20 Jer Noble <jer.no...@apple.com>
+
+ REGRESSION(r243958): Unnecessary deactivation of AudioSession (PLT Regression)
+ https://bugs.webkit.org/show_bug.cgi?id=197123
+ <rdar://problem/49783264>
+
+ Reviewed by Per Arne Vollan.
+
+ Only set m_becameActive if we actually activated the AudioSession before starting playback. This
+ avoids unnecessarily deactivating the AudioSession in processWillSuspend().
+
+ * platform/audio/PlatformMediaSessionManager.cpp:
+ (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
+
2019-04-19 Devin Rousso <drou...@apple.com>
Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting Web Inspector
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (244489 => 244490)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2019-04-20 19:16:22 UTC (rev 244489)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2019-04-20 23:46:25 UTC (rev 244490)
@@ -219,12 +219,15 @@
}
#if USE(AUDIO_SESSION)
- if (activeAudioSessionRequired() && !AudioSession::sharedSession().tryToSetActive(true)) {
- ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false failed to set active AudioSession");
- return false;
+ if (activeAudioSessionRequired()) {
+ if (!AudioSession::sharedSession().tryToSetActive(true)) {
+ ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false failed to set active AudioSession");
+ return false;
+ }
+
+ ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " sucessfully activated AudioSession");
+ m_becameActive = true;
}
-
- m_becameActive = true;
#endif
if (m_interrupted)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
