Title: [244495] trunk/Source/WebCore
- Revision
- 244495
- Author
- da...@apple.com
- Date
- 2019-04-21 17:24:03 -0700 (Sun, 21 Apr 2019)
Log Message
WHLSLPrepare.cpp always recompiles, even if nothing was changed
https://bugs.webkit.org/show_bug.cgi?id=197151
Reviewed by Dan Bernstein.
* DerivedSources-input.xcfilelist: Script updated this automatically after
DerivedSources.make was corrected.
* DerivedSources-output.xcfilelist: Ditto, although I had to manually remove
one bogus leftover reference to WHLSLStandardLibrary.cpp.
* DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to
no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
was running on every build, instead of only when one of the dependencies changed.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244494 => 244495)
--- trunk/Source/WebCore/ChangeLog 2019-04-21 21:10:31 UTC (rev 244494)
+++ trunk/Source/WebCore/ChangeLog 2019-04-22 00:24:03 UTC (rev 244495)
@@ -1,3 +1,20 @@
+2019-04-21 Darin Adler <da...@apple.com>
+
+ WHLSLPrepare.cpp always recompiles, even if nothing was changed
+ https://bugs.webkit.org/show_bug.cgi?id=197151
+
+ Reviewed by Dan Bernstein.
+
+ * DerivedSources-input.xcfilelist: Script updated this automatically after
+ DerivedSources.make was corrected.
+ * DerivedSources-output.xcfilelist: Ditto, although I had to manually remove
+ one bogus leftover reference to WHLSLStandardLibrary.cpp.
+
+ * DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to
+ no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
+ was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
+ was running on every build, instead of only when one of the dependencies changed.
+
2019-04-20 Said Abou-Hallawa <s...@apple.com>
REGRESSION (r243137): SVGViewElement.viewTarget should not return a new object
Modified: trunk/Source/WebCore/DerivedSources-input.xcfilelist (244494 => 244495)
--- trunk/Source/WebCore/DerivedSources-input.xcfilelist 2019-04-21 21:10:31 UTC (rev 244494)
+++ trunk/Source/WebCore/DerivedSources-input.xcfilelist 2019-04-22 00:24:03 UTC (rev 244495)
@@ -15,6 +15,7 @@
$(_javascript_CORE_PRIVATE_HEADERS_DIR)/lazywriter.py
$(_javascript_CORE_PRIVATE_HEADERS_DIR)/make-js-file-arrays.py
$(_javascript_CORE_PRIVATE_HEADERS_DIR)/wkbuiltins.py
+$(_javascript_CORE_PRIVATE_HEADERS_DIR)/xxd.pl
$(PROJECT_DIR)/Configurations/FeatureDefines.xcconfig
$(PROJECT_DIR)/DerivedSources.make
$(PROJECT_DIR)/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl
@@ -341,6 +342,7 @@
$(PROJECT_DIR)/Modules/webgpu/GPUTextureUsage.idl
$(PROJECT_DIR)/Modules/webgpu/GPUVertexAttributeDescriptor.idl
$(PROJECT_DIR)/Modules/webgpu/GPUVertexInputDescriptor.idl
+$(PROJECT_DIR)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
$(PROJECT_DIR)/Modules/webgpu/WebGPU.idl
$(PROJECT_DIR)/Modules/webgpu/WebGPUAdapter.idl
$(PROJECT_DIR)/Modules/webgpu/WebGPUBindGroup.idl
Modified: trunk/Source/WebCore/DerivedSources-output.xcfilelist (244494 => 244495)
--- trunk/Source/WebCore/DerivedSources-output.xcfilelist 2019-04-21 21:10:31 UTC (rev 244494)
+++ trunk/Source/WebCore/DerivedSources-output.xcfilelist 2019-04-22 00:24:03 UTC (rev 244495)
@@ -2084,7 +2084,7 @@
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentScripts.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentScriptsData.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentStyleSheets.h
-$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltins.cpp
Modified: trunk/Source/WebCore/DerivedSources.make (244494 => 244495)
--- trunk/Source/WebCore/DerivedSources.make 2019-04-21 21:10:31 UTC (rev 244494)
+++ trunk/Source/WebCore/DerivedSources.make 2019-04-22 00:24:03 UTC (rev 244495)
@@ -1633,10 +1633,10 @@
# WHLSL Standard Library
-all : WHLSLStandardLibrary.cpp
+all : WHLSLStandardLibrary.h
-WHLSLStandardLibrary.cpp : $(_javascript_Core_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
- $(PERL) $(_javascript_Core_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt WHLSLStandardLibrary.h
+WHLSLStandardLibrary.h : $(_javascript_Core_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
+ $(PERL) $(_javascript_Core_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $<
# --------
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
