Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (244548 => 244549)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-04-23 17:53:26 UTC (rev 244548)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-04-23 17:54:35 UTC (rev 244549)
@@ -24,7 +24,12 @@
from buildbot.process import factory
from buildbot.steps import trigger
-from steps import *
+from steps import (ApplyPatch, CheckOutSource, CheckPatchRelevance, CheckStyle,
+ CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, ConfigureBuild,
+ DownloadBuiltProduct, ExtractBuiltProduct, KillOldProcesses,
+ PrintConfiguration, ReRunJavaScriptCoreTests, RunAPITests, RunBindingsTests,
+ RunJavaScriptCoreTests, RunJavaScriptCoreTestsToT, RunWebKit1Tests, RunWebKitPerlTests,
+ RunWebKitPyTests, RunWebKitTests, UnApplyPatchIfRequired, ValidatePatch)
class Factory(factory.BuildFactory):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py (244548 => 244549)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-04-23 17:53:26 UTC (rev 244548)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-04-23 17:54:35 UTC (rev 244549)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -30,7 +30,10 @@
from buildbot.worker import Worker
from buildbot.util import identifiers as buildbot_identifiers
-from factories import *
+from factories import (APITestsFactory, BindingsFactory, BuildFactory, Factory, GTKFactory,
+ JSCTestsFactory, StyleFactory, TestFactory, WPEFactory, WebKitPerlFactory,
+ WebKitPyFactory, WinCairoFactory, WindowsFactory, iOSBuildFactory, iOSTestsFactory,
+ macOSBuildFactory, macOSWK1Factory, macOSWK2Factory)
BUILDER_NAME_LENGTH_LIMIT = 70
STEP_NAME_LENGTH_LIMIT = 50
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (244548 => 244549)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-04-23 17:53:26 UTC (rev 244548)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-04-23 17:54:35 UTC (rev 244549)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -34,7 +34,14 @@
from twisted.python import failure, log
from twisted.trial import unittest
-from steps import *
+from steps import (AnalyzeAPITestsResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
+ CheckOutSource, CheckPatchRelevance, CheckStyle, CleanBuild, CleanWorkingDirectory,
+ CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, CompileWebKitToT, ConfigureBuild,
+ DownloadBuiltProduct, ExtractBuiltProduct, ExtractTestResults, KillOldProcesses,
+ PrintConfiguration, ReRunAPITests, ReRunJavaScriptCoreTests, RunAPITests, RunAPITestsWithoutPatch,
+ RunBindingsTests, RunJavaScriptCoreTests, RunJavaScriptCoreTestsToT, RunWebKit1Tests, RunWebKitPerlTests,
+ RunWebKitPyTests, RunWebKitTests, TestWithFailureCount, Trigger, UnApplyPatchIfRequired, UploadBuiltProduct,
+ UploadTestResults, ValidatePatch)
# Workaround for https://github.com/buildbot/buildbot/issues/4669
from buildbot.test.fake.fakebuild import FakeBuild
Modified: trunk/Tools/ChangeLog (244548 => 244549)
--- trunk/Tools/ChangeLog 2019-04-23 17:53:26 UTC (rev 244548)
+++ trunk/Tools/ChangeLog 2019-04-23 17:54:35 UTC (rev 244549)
@@ -1,5 +1,16 @@
2019-04-23 Aakash Jain <[email protected]>
+ [ews-build] Use explicit imports instead of wildcard imports
+ https://bugs.webkit.org/show_bug.cgi?id=197194
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/factories.py:
+ * BuildSlaveSupport/ews-build/loadConfig.py:
+ * BuildSlaveSupport/ews-build/steps_unittest.py:
+
+2019-04-23 Aakash Jain <[email protected]>
+
[ews-build] Add unit tests for DownloadBuiltProduct
https://bugs.webkit.org/show_bug.cgi?id=197193
