Title: [244632] trunk/Source/WebCore
- Revision
- 244632
- Author
- [email protected]
- Date
- 2019-04-24 18:11:00 -0700 (Wed, 24 Apr 2019)
Log Message
Do not restart WebRTC stats timer if backend is stopped
https://bugs.webkit.org/show_bug.cgi?id=197257
<rdar://problem/50095879>
Reviewed by Eric Carlson.
We used to stop and reschedule the stat gathering timer in case the
gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244631 => 244632)
--- trunk/Source/WebCore/ChangeLog 2019-04-25 00:49:08 UTC (rev 244631)
+++ trunk/Source/WebCore/ChangeLog 2019-04-25 01:11:00 UTC (rev 244632)
@@ -1,3 +1,17 @@
+2019-04-24 Youenn Fablet <[email protected]>
+
+ Do not restart WebRTC stats timer if backend is stopped
+ https://bugs.webkit.org/show_bug.cgi?id=197257
+ <rdar://problem/50095879>
+
+ Reviewed by Eric Carlson.
+
+ We used to stop and reschedule the stat gathering timer in case the
+ gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
2019-04-24 Andres Gonzalez <[email protected]>
Flaky crash under WebCore::AXObjectCache::stopCachingComputedObjectAttributes()
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (244631 => 244632)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2019-04-25 00:49:08 UTC (rev 244631)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2019-04-25 01:11:00 UTC (rev 244632)
@@ -847,7 +847,7 @@
m_statsFirstDeliveredTimestamp = timestamp;
callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
- if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
+ if (m_backend && m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
m_statsLogTimer.stop();
m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
