Title: [244824] trunk
- Revision
- 244824
- Author
- [email protected]
- Date
- 2019-05-01 09:34:31 -0700 (Wed, 01 May 2019)
Log Message
LayoutTests/imported/w3c:
Kept alive loaders should use the redirected request in case of redirections
https://bugs.webkit.org/show_bug.cgi?id=197337
Reviewed by Alex Christensen.
* web-platform-tests/fetch/api/basic/keepalive-expected.txt:
Source/WebKit:
Kept alive loaders should use the redirected request in case of redirections
https://bugs.webkit.org/show_bug.cgi?id=197337
Reviewed by Alex Christensen.
Instead of using the request, the redirected request should be used in case of redirection.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
LayoutTests:
Enable Fetch Keep Alive by default
https://bugs.webkit.org/show_bug.cgi?id=197331
Reviewed by Alex Christensen.
* platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (244823 => 244824)
--- trunk/LayoutTests/ChangeLog 2019-05-01 15:56:34 UTC (rev 244823)
+++ trunk/LayoutTests/ChangeLog 2019-05-01 16:34:31 UTC (rev 244824)
@@ -1,3 +1,12 @@
+2019-05-01 Youenn Fablet <[email protected]>
+
+ Enable Fetch Keep Alive by default
+ https://bugs.webkit.org/show_bug.cgi?id=197331
+
+ Reviewed by Alex Christensen.
+
+ * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt: Added.
+
2019-05-01 Eric Carlson <[email protected]>
XMLHttpRequest should propagate user gestures for media playback
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (244823 => 244824)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-01 15:56:34 UTC (rev 244823)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-01 16:34:31 UTC (rev 244824)
@@ -1,3 +1,12 @@
+2019-05-01 Youenn Fablet <[email protected]>
+
+ Kept alive loaders should use the redirected request in case of redirections
+ https://bugs.webkit.org/show_bug.cgi?id=197337
+
+ Reviewed by Alex Christensen.
+
+ * web-platform-tests/fetch/api/basic/keepalive-expected.txt:
+
2019-04-29 Darin Adler <[email protected]>
WebKit has too much of its own UTF-8 code and should rely more on ICU's UTF-8 support
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt (244823 => 244824)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt 2019-05-01 15:56:34 UTC (rev 244823)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt 2019-05-01 16:34:31 UTC (rev 244824)
@@ -1,3 +1,3 @@
-FAIL Fetch API: keepalive handling assert_equals: expected (string) "on" but got (object) null
+PASS Fetch API: keepalive handling
Copied: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt (from rev 244823, trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt) (0 => 244824)
--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/basic/keepalive-expected.txt 2019-05-01 16:34:31 UTC (rev 244824)
@@ -0,0 +1,3 @@
+
+FAIL Fetch API: keepalive handling assert_equals: expected (string) "on" but got (object) null
+
Modified: trunk/Source/WebKit/ChangeLog (244823 => 244824)
--- trunk/Source/WebKit/ChangeLog 2019-05-01 15:56:34 UTC (rev 244823)
+++ trunk/Source/WebKit/ChangeLog 2019-05-01 16:34:31 UTC (rev 244824)
@@ -1,3 +1,16 @@
+2019-05-01 Youenn Fablet <[email protected]>
+
+ Kept alive loaders should use the redirected request in case of redirections
+ https://bugs.webkit.org/show_bug.cgi?id=197337
+
+ Reviewed by Alex Christensen.
+
+ Instead of using the request, the redirected request should be used in case of redirection.
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
+ (WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
+
2019-04-29 Darin Adler <[email protected]>
WebKit has too much of its own UTF-8 code and should rely more on ICU's UTF-8 support
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (244823 => 244824)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-05-01 15:56:34 UTC (rev 244823)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-05-01 16:34:31 UTC (rev 244824)
@@ -656,7 +656,7 @@
ASSERT(!isSynchronous());
if (m_isKeptAlive) {
- continueWillSendRequest(WTFMove(request), false);
+ continueWillSendRequest(WTFMove(redirectRequest), false);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
