Title: [102499] trunk/Source/WebKit2
Revision
102499
Author
commit-qu...@webkit.org
Date
2011-12-09 17:28:28 -0800 (Fri, 09 Dec 2011)

Log Message

[Qt][WK2] Unskip API tests
https://bugs.webkit.org/show_bug.cgi?id=74180

Patch by Jesus Sanchez-Palencia <jesus.palen...@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.

Unskip API tests for geolocation and _javascript_ dialogs.

* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (102498 => 102499)


--- trunk/Source/WebKit2/ChangeLog	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 01:28:28 UTC (rev 102499)
@@ -1,3 +1,15 @@
+2011-12-09  Jesus Sanchez-Palencia  <jesus.palen...@openbossa.org>
+
+        [Qt][WK2] Unskip API tests
+        https://bugs.webkit.org/show_bug.cgi?id=74180
+
+        Reviewed by Tor Arne Vestbø.
+
+        Unskip API tests for geolocation and _javascript_ dialogs.
+
+        * UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
+        * UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
+
 2011-12-07  Mark Rowe  <mr...@apple.com>
 
         <http://webkit.org/b/74061> WebProcess and PluginProcess should inherit environment

Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml (102498 => 102499)


--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml	2011-12-10 01:28:28 UTC (rev 102499)
@@ -45,7 +45,6 @@
         }
 
         function test_permissionRequest() {
-            skip("Waiting for qtlocation being included in the bot")
             compare(spy.count, 0)
             webView.load(Qt.resolvedUrl("../common/geolocation.html"))
             spy.wait()

Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml (102498 => 102499)


--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml	2011-12-10 01:26:36 UTC (rev 102498)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml	2011-12-10 01:28:28 UTC (rev 102499)
@@ -81,7 +81,6 @@
         }
 
         function test_alertWithoutDialog() {
-            skip("Setting experimental properties from JS code isn't working")
             webView.experimental.alertDialog = null
             webView.load(Qt.resolvedUrl("../common/alert.html"))
             loadSpy.wait()
@@ -98,7 +97,6 @@
         }
 
         function test_confirmWithoutDialog() {
-            skip("Setting experimental properties from JS code isn't working")
             webView.experimental.confirmDialog = null
             webView.load(Qt.resolvedUrl("../common/confirm.html"))
             loadSpy.wait()
@@ -116,7 +114,6 @@
         }
 
         function test_promptWithoutDialog() {
-            skip("Setting experimental properties from JS code isn't working")
             webView.experimental.promptDialog = null
             webView.load(Qt.resolvedUrl("../common/prompt.html"))
             loadSpy.wait()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to