Diff
Modified: trunk/LayoutTests/ChangeLog (102500 => 102501)
--- trunk/LayoutTests/ChangeLog 2011-12-10 01:31:15 UTC (rev 102500)
+++ trunk/LayoutTests/ChangeLog 2011-12-10 01:39:11 UTC (rev 102501)
@@ -1,3 +1,16 @@
+2011-12-09 Mark Pilgrim <pilg...@chromium.org>
+
+ [FileSystem API] Entry.remove successCallback is required
+ https://bugs.webkit.org/show_bug.cgi?id=69639
+
+ Reviewed by Adam Barth.
+
+ * fast/filesystem/resources/simple-required-arguments-remove.js: Added.
+ (errorCallback):
+ (successCallback):
+ * fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
+ * fast/filesystem/simple-required-arguments-remove.html: Added.
+
2011-12-09 Tim Horton <timothy_hor...@apple.com>
background-image transitions trigger between equivalent images
Added: trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js (0 => 102501)
--- trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js (rev 0)
+++ trunk/LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js 2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,25 @@
+if (this.importScripts) {
+ importScripts('../resources/fs-worker-common.js');
+ importScripts('../resources/fs-test-util.js');
+}
+
+description("Entry.remove() required arguments test.");
+
+var fileSystem = null;
+
+function errorCallback(error) {
+ debug("Error occured while requesting a TEMPORARY file system:" + error.code);
+ finishJSTest();
+}
+
+function successCallback(fs) {
+ fileSystem = fs;
+ debug("Successfully obtained TEMPORARY FileSystem:" + fileSystem.name);
+ root = evalAndLog("root = fileSystem.root");
+ shouldThrow("root.remove()");
+ finishJSTest();
+}
+
+var jsTestIsAsync = true;
+evalAndLog("webkitRequestFileSystem(TEMPORARY, 100, successCallback, errorCallback);");
+var successfullyParsed = true;
Added: trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt (0 => 102501)
--- trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove-expected.txt 2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,13 @@
+Entry.remove() required arguments test.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+webkitRequestFileSystem(TEMPORARY, 100, successCallback, errorCallback);
+Successfully obtained TEMPORARY FileSystem:file__0:Temporary
+root = fileSystem.root
+PASS root.remove() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html (0 => 102501)
--- trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html (rev 0)
+++ trunk/LayoutTests/fast/filesystem/simple-required-arguments-remove.html 2011-12-10 01:39:11 UTC (rev 102501)
@@ -0,0 +1,12 @@
+<html>
+<head>
+<link rel="stylesheet" href=""
+<script src=""
+</head>
+<body>
+<p id="description"></p>
+<div id="console"></div>
+<script src=""
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (102500 => 102501)
--- trunk/Source/WebCore/ChangeLog 2011-12-10 01:31:15 UTC (rev 102500)
+++ trunk/Source/WebCore/ChangeLog 2011-12-10 01:39:11 UTC (rev 102501)
@@ -1,3 +1,14 @@
+2011-12-09 Mark Pilgrim <pilg...@chromium.org>
+
+ [FileSystem API] Entry.remove successCallback is required
+ https://bugs.webkit.org/show_bug.cgi?id=69639
+
+ Reviewed by Adam Barth.
+
+ Test: fast/filesystem/simple-required-arguments-remove.html
+
+ * fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter
+
2011-12-09 Tim Horton <timothy_hor...@apple.com>
background-image transitions trigger between equivalent images
Modified: trunk/Source/WebCore/fileapi/Entry.idl (102500 => 102501)
--- trunk/Source/WebCore/fileapi/Entry.idl 2011-12-10 01:31:15 UTC (rev 102500)
+++ trunk/Source/WebCore/fileapi/Entry.idl 2011-12-10 01:39:11 UTC (rev 102501)
@@ -44,7 +44,7 @@
void moveTo(in DirectoryEntry parent, in [Optional, ConvertUndefinedOrNullToNullString] DOMString name, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
void copyTo(in DirectoryEntry parent, in [Optional, ConvertUndefinedOrNullToNullString] DOMString name, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
DOMString toURL();
- void remove(in [Optional, Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
+ void remove(in [Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
void getParent(in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
};
}
