Title: [245283] trunk/Source/WebKit
- Revision
- 245283
- Author
- [email protected]
- Date
- 2019-05-14 09:22:32 -0700 (Tue, 14 May 2019)
Log Message
[iOS] Cannot tab or shift + tab out of address bar on google.com
https://bugs.webkit.org/show_bug.cgi?id=197859
<rdar://problem/46651565>
Patch by Daniel Bates <[email protected]> on 2019-05-14
Reviewed by Darin Adler.
Non-editable elements can participate in tab cycling via the HTML tabindex attribute.
We should allow setting the initial focus to such an element when transitioning from
the chrome (e.g. address bar) to the web page.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (245282 => 245283)
--- trunk/Source/WebKit/ChangeLog 2019-05-14 16:18:24 UTC (rev 245282)
+++ trunk/Source/WebKit/ChangeLog 2019-05-14 16:22:32 UTC (rev 245283)
@@ -1,3 +1,18 @@
+2019-05-14 Daniel Bates <[email protected]>
+
+ [iOS] Cannot tab or shift + tab out of address bar on google.com
+ https://bugs.webkit.org/show_bug.cgi?id=197859
+ <rdar://problem/46651565>
+
+ Reviewed by Darin Adler.
+
+ Non-editable elements can participate in tab cycling via the HTML tabindex attribute.
+ We should allow setting the initial focus to such an element when transitioning from
+ the chrome (e.g. address bar) to the web page.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
+
2019-05-14 Alex Christensen <[email protected]>
Add a unit test for client certificate authentication
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (245282 => 245283)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-05-14 16:18:24 UTC (rev 245282)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-05-14 16:22:32 UTC (rev 245283)
@@ -3794,12 +3794,9 @@
- (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler
{
- auto completionHandlerCopy = Block_copy(completionHandler);
- RetainPtr<WKContentView> view = self;
- _page->setInitialFocus(selectingForward, false, WebKit::WebKeyboardEvent(), [view, completionHandlerCopy](WebKit::CallbackBase::Error) {
- BOOL didBecomeFirstResponder = view->_focusedElementInformation.elementType != WebKit::InputType::None && [view becomeFirstResponder];
- completionHandlerCopy(didBecomeFirstResponder);
- Block_release(completionHandlerCopy);
+ constexpr bool isKeyboardEventValid = false;
+ _page->setInitialFocus(selectingForward, isKeyboardEventValid, { }, [protectedSelf = retainPtr(self), completionHandler = makeBlockPtr(completionHandler)] (auto) {
+ completionHandler([protectedSelf becomeFirstResponder]);
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
