Title: [245383] branches/safari-608.1.24-branch
Revision
245383
Author
[email protected]
Date
2019-05-15 22:43:27 -0700 (Wed, 15 May 2019)

Log Message

Cherry-pick r245322. rdar://problem/50107679

    Allow NSFileCoordinator to be called from WebContent process
    https://bugs.webkit.org/show_bug.cgi?id=197895
    <rdar://problem/50107679>

    Patch by Alex Christensen <[email protected]> on 2019-05-15
    Reviewed by Brent Fulgham.

    Source/WebKit:

    * WebProcess/com.apple.WebProcess.sb.in:
    Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.

    Tools:

    Add a unit test that verifies calling the block succeeds.

    * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
    (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-608.1.24-branch/Source/WebKit/ChangeLog (245382 => 245383)


--- branches/safari-608.1.24-branch/Source/WebKit/ChangeLog	2019-05-16 05:43:24 UTC (rev 245382)
+++ branches/safari-608.1.24-branch/Source/WebKit/ChangeLog	2019-05-16 05:43:27 UTC (rev 245383)
@@ -1,5 +1,41 @@
 2019-05-15  Kocsen Chung  <[email protected]>
 
+        Cherry-pick r245322. rdar://problem/50107679
+
+    Allow NSFileCoordinator to be called from WebContent process
+    https://bugs.webkit.org/show_bug.cgi?id=197895
+    <rdar://problem/50107679>
+    
+    Patch by Alex Christensen <[email protected]> on 2019-05-15
+    Reviewed by Brent Fulgham.
+    
+    Source/WebKit:
+    
+    * WebProcess/com.apple.WebProcess.sb.in:
+    Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
+    
+    Tools:
+    
+    Add a unit test that verifies calling the block succeeds.
+    
+    * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
+    (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-15  Alex Christensen  <[email protected]>
+
+            Allow NSFileCoordinator to be called from WebContent process
+            https://bugs.webkit.org/show_bug.cgi?id=197895
+            <rdar://problem/50107679>
+
+            Reviewed by Brent Fulgham.
+
+            * WebProcess/com.apple.WebProcess.sb.in:
+            Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
+
+2019-05-15  Kocsen Chung  <[email protected]>
+
         Cherry-pick r245320. rdar://problem/48737122
 
     Web Automation: elements larger than the viewport have incorrect in-view center point

Modified: branches/safari-608.1.24-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (245382 => 245383)


--- branches/safari-608.1.24-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-05-16 05:43:24 UTC (rev 245382)
+++ branches/safari-608.1.24-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2019-05-16 05:43:27 UTC (rev 245383)
@@ -593,6 +593,9 @@
 (allow mach-lookup
        (global-name "com.apple.webinspector"))
 
+(allow mach-lookup
+    (global-name "com.apple.FileCoordination"))
+
 ;; Various services required by AppKit and other frameworks
 (allow mach-lookup
 #if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
@@ -986,6 +989,9 @@
         (syscall-number SYS_quotactl) ;; <rdar://problem/49945031>
         (syscall-number SYS_stat64_extended) ;; <rdar://problem/50473330>
         (syscall-number SYS_lstat64_extended)
+        (syscall-number SYS_iopolicysys)
+        (syscall-number SYS_workq_open)
+        (syscall-number SYS_getgroups)
     )
 )
 

Modified: branches/safari-608.1.24-branch/Tools/ChangeLog (245382 => 245383)


--- branches/safari-608.1.24-branch/Tools/ChangeLog	2019-05-16 05:43:24 UTC (rev 245382)
+++ branches/safari-608.1.24-branch/Tools/ChangeLog	2019-05-16 05:43:27 UTC (rev 245383)
@@ -1,5 +1,43 @@
 2019-05-15  Kocsen Chung  <[email protected]>
 
+        Cherry-pick r245322. rdar://problem/50107679
+
+    Allow NSFileCoordinator to be called from WebContent process
+    https://bugs.webkit.org/show_bug.cgi?id=197895
+    <rdar://problem/50107679>
+    
+    Patch by Alex Christensen <[email protected]> on 2019-05-15
+    Reviewed by Brent Fulgham.
+    
+    Source/WebKit:
+    
+    * WebProcess/com.apple.WebProcess.sb.in:
+    Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
+    
+    Tools:
+    
+    Add a unit test that verifies calling the block succeeds.
+    
+    * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
+    (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-15  Alex Christensen  <[email protected]>
+
+            Allow NSFileCoordinator to be called from WebContent process
+            https://bugs.webkit.org/show_bug.cgi?id=197895
+            <rdar://problem/50107679>
+
+            Reviewed by Brent Fulgham.
+
+            Add a unit test that verifies calling the block succeeds.
+
+            * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
+            (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+
+2019-05-15  Kocsen Chung  <[email protected]>
+
         Cherry-pick r245156. rdar://problem/50590818
 
     Refine AudioSession route sharing policy

Modified: branches/safari-608.1.24-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm (245382 => 245383)


--- branches/safari-608.1.24-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm	2019-05-16 05:43:24 UTC (rev 245382)
+++ branches/safari-608.1.24-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm	2019-05-16 05:43:27 UTC (rev 245383)
@@ -52,6 +52,13 @@
 
     _interface = [_WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:@protocol(AdditionalReadAccessAllowedURLsProtocol)];
     [[browserContextController _remoteObjectRegistry] registerExportedObject:self interface:_interface.get()];
+
+    __block bool blockCalled = false;
+    NSFileCoordinator *coordinator = [[NSFileCoordinator alloc] initWithFilePresenter:nil];
+    [coordinator coordinateReadingItemAtURL:[NSURL fileURLWithPath:@"/Applications/Safari.app"] options:NSFileCoordinatorReadingWithoutChanges error:nil byAccessor:^(NSURL *newURL) {
+        blockCalled = true;
+    }];
+    ASSERT(blockCalled);
 }
 
 - (void)dealloc
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to