Title: [245614] trunk/Source/WebCore
- Revision
- 245614
- Author
- jer.no...@apple.com
- Date
- 2019-05-21 22:37:17 -0700 (Tue, 21 May 2019)
Log Message
Media controls don't show in WK2 video fullscreen sometimes
https://bugs.webkit.org/show_bug.cgi?id=198094
<rdar://problem/50970661>
Reviewed by Tim Horton.
Ensure that the WebAVPlayerLayer never allows hit testing, as this keeps touches from reaching
AVKit's controls.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer init]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245613 => 245614)
--- trunk/Source/WebCore/ChangeLog 2019-05-22 03:18:03 UTC (rev 245613)
+++ trunk/Source/WebCore/ChangeLog 2019-05-22 05:37:17 UTC (rev 245614)
@@ -1,3 +1,17 @@
+2019-05-21 Jer Noble <jer.no...@apple.com>
+
+ Media controls don't show in WK2 video fullscreen sometimes
+ https://bugs.webkit.org/show_bug.cgi?id=198094
+ <rdar://problem/50970661>
+
+ Reviewed by Tim Horton.
+
+ Ensure that the WebAVPlayerLayer never allows hit testing, as this keeps touches from reaching
+ AVKit's controls.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (-[WebAVPlayerLayer init]):
+
2019-05-21 Saam barati <sbar...@apple.com>
WHLSL: Add an AST dumper
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (245613 => 245614)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-05-22 03:18:03 UTC (rev 245613)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-05-22 05:37:17 UTC (rev 245614)
@@ -44,6 +44,7 @@
#import <objc/message.h>
#import <objc/runtime.h>
#import <pal/spi/cocoa/AVKitSPI.h>
+#import <pal/spi/cocoa/QuartzCoreSPI.h>
#import <pal/spi/ios/UIKitSPI.h>
#import <wtf/RetainPtr.h>
#import <wtf/text/CString.h>
@@ -203,7 +204,8 @@
{
self = [super init];
if (self) {
- [self setMasksToBounds:YES];
+ self.masksToBounds = YES;
+ self.allowsHitTesting = NO;
_videoGravity = AVLayerVideoGravityResizeAspect;
}
return self;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
