Title: [245748] trunk/Source/WebCore
- Revision
- 245748
- Author
- [email protected]
- Date
- 2019-05-24 11:26:45 -0700 (Fri, 24 May 2019)
Log Message
Make sure completion handler is always called in SWServer::startSuspension
https://bugs.webkit.org/show_bug.cgi?id=198215
Reviewed by Alex Christensen.
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::startSuspension):
Make sure completion handler is called in case of no registration store.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245747 => 245748)
--- trunk/Source/WebCore/ChangeLog 2019-05-24 17:47:28 UTC (rev 245747)
+++ trunk/Source/WebCore/ChangeLog 2019-05-24 18:26:45 UTC (rev 245748)
@@ -1,3 +1,14 @@
+2019-05-24 Youenn Fablet <[email protected]>
+
+ Make sure completion handler is always called in SWServer::startSuspension
+ https://bugs.webkit.org/show_bug.cgi?id=198215
+
+ Reviewed by Alex Christensen.
+
+ * workers/service/server/SWServer.cpp:
+ (WebCore::SWServer::startSuspension):
+ Make sure completion handler is called in case of no registration store.
+
2019-05-24 Ryosuke Niwa <[email protected]>
Asssertion failure in dispatchSubtreeModifiedEvent due to TextFieldInputType updating UA shadow tree inside Element::removedFromAncestor
Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (245747 => 245748)
--- trunk/Source/WebCore/workers/service/server/SWServer.cpp 2019-05-24 17:47:28 UTC (rev 245747)
+++ trunk/Source/WebCore/workers/service/server/SWServer.cpp 2019-05-24 18:26:45 UTC (rev 245748)
@@ -220,8 +220,11 @@
void SWServer::startSuspension(CompletionHandler<void()>&& completionHandler)
{
- if (m_registrationStore)
- m_registrationStore->startSuspension(WTFMove(completionHandler));
+ if (!m_registrationStore) {
+ completionHandler();
+ return;
+ }
+ m_registrationStore->startSuspension(WTFMove(completionHandler));
}
void SWServer::endSuspension()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
