Title: [245750] trunk/Source/WebInspectorUI
- Revision
- 245750
- Author
- [email protected]
- Date
- 2019-05-24 12:01:48 -0700 (Fri, 24 May 2019)
Log Message
Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
https://bugs.webkit.org/show_bug.cgi?id=198221
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (245749 => 245750)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-05-24 18:55:28 UTC (rev 245749)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-05-24 19:01:48 UTC (rev 245750)
@@ -1,3 +1,13 @@
+2019-05-24 Devin Rousso <[email protected]>
+
+ Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
+ https://bugs.webkit.org/show_bug.cgi?id=198221
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
+
2019-05-23 Devin Rousso <[email protected]>
Web Inspector: prevent stripping `console.assert` if it's used inside a string
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (245749 => 245750)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-05-24 18:55:28 UTC (rev 245749)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-05-24 19:01:48 UTC (rev 245750)
@@ -222,9 +222,11 @@
generalSettingsView.addSeparator();
- generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
+ if (InspectorBackend.domains.DOM && InspectorBackend.domains.DOM.setInspectModeEnabled && InspectorBackend.domains.DOM.setInspectModeEnabled.supports("showRulers")) {
+ generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
- generalSettingsView.addSeparator();
+ generalSettingsView.addSeparator();
+ }
const zoomLevels = [0.6, 0.8, 1, 1.2, 1.4, 1.6, 1.8, 2, 2.2, 2.4];
const zoomValues = zoomLevels.map((level) => [level, Number.percentageString(level, 0)]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
