Title: [245980] trunk/Source/WebCore
- Revision
- 245980
- Author
- commit-qu...@webkit.org
- Date
- 2019-05-31 13:23:31 -0700 (Fri, 31 May 2019)
Log Message
Inserting a newline in contenteditable causes two characters to be added instead of one
https://bugs.webkit.org/show_bug.cgi?id=197894
<rdar://problems/49700998>
Patch by Andres Gonzalez <andresg...@apple.com> on 2019-05-31
Reviewed by Chris Fleizach.
No new test is necessary since this is a comment change.
Removed radar reference from code.
* editing/Editing.cpp:
(WebCore::visiblePositionForIndexUsingCharacterIterator):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245979 => 245980)
--- trunk/Source/WebCore/ChangeLog 2019-05-31 20:00:07 UTC (rev 245979)
+++ trunk/Source/WebCore/ChangeLog 2019-05-31 20:23:31 UTC (rev 245980)
@@ -1,3 +1,18 @@
+2019-05-31 Andres Gonzalez <andresg...@apple.com>
+
+ Inserting a newline in contenteditable causes two characters to be added instead of one
+ https://bugs.webkit.org/show_bug.cgi?id=197894
+ <rdar://problems/49700998>
+
+ Reviewed by Chris Fleizach.
+
+ No new test is necessary since this is a comment change.
+
+ Removed radar reference from code.
+
+ * editing/Editing.cpp:
+ (WebCore::visiblePositionForIndexUsingCharacterIterator):
+
2019-05-31 Tim Horton <timothy_hor...@apple.com>
Optionally respect device management restrictions when loading from the network
Modified: trunk/Source/WebCore/editing/Editing.cpp (245979 => 245980)
--- trunk/Source/WebCore/editing/Editing.cpp 2019-05-31 20:00:07 UTC (rev 245979)
+++ trunk/Source/WebCore/editing/Editing.cpp 2019-05-31 20:23:31 UTC (rev 245980)
@@ -1123,7 +1123,7 @@
it.advance(index - 1);
if (!it.atEnd() && it.text()[0] == '\n') {
- // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines (see rdar://5192593)
+ // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
auto range = it.range();
if (range->startPosition() == range->endPosition()) {
it.advance(1);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
