Title: [246050] trunk/Tools
- Revision
- 246050
- Author
- [email protected]
- Date
- 2019-06-03 14:10:36 -0700 (Mon, 03 Jun 2019)
Log Message
[ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
https://bugs.webkit.org/show_bug.cgi?id=198423
<rdar://problem/51305247>
Reviewed by Youenn Fablet.
IDBDatabase receives error event on network process crash, so we don't need to check it periodically.
* TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (246049 => 246050)
--- trunk/Tools/ChangeLog 2019-06-03 21:07:45 UTC (rev 246049)
+++ trunk/Tools/ChangeLog 2019-06-03 21:10:36 UTC (rev 246050)
@@ -1,3 +1,15 @@
+2019-06-03 Sihui Liu <[email protected]>
+
+ [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
+ https://bugs.webkit.org/show_bug.cgi?id=198423
+ <rdar://problem/51305247>
+
+ Reviewed by Youenn Fablet.
+
+ IDBDatabase receives error event on network process crash, so we don't need to check it periodically.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html:
+
2019-06-03 Rob Buis <[email protected]>
Implement imagesrcset and imagesizes attributes on link rel=preload
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html (246049 => 246050)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html 2019-06-03 21:07:45 UTC (rev 246049)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html 2019-06-03 21:10:36 UTC (rev 246050)
@@ -3,17 +3,6 @@
var db;
-function put() {
- var os = db.transaction(["TestObjectStore"], "readwrite").objectStore("TestObjectStore");
- var request = os.put('value', 'key');
- request._onsuccess_ = (event) => {
- setTimeout(put, 100);
- }
- request._onerror_ = (event)=> {
- window.webkit.messageHandlers.testHandler.postMessage("Network Process Crashed");
- }
-}
-
window.localStorage.setItem("local", "storage");
window.sessionStorage.setItem("session", "storage");
@@ -22,7 +11,7 @@
window.webkit.messageHandlers.testHandler.postMessage("local:" + window.localStorage.getItem("local"));
window.webkit.messageHandlers.testHandler.postMessage("session:"+ window.sessionStorage.getItem("session"));
db = request.result;
- put();
+ db._onerror_ = () => window.webkit.messageHandlers.testHandler.postMessage("Network Process Crashed");
}
request._onupgradeneeded_ = function(event) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
