Title: [246113] trunk/LayoutTests
Revision
246113
Author
za...@apple.com
Date
2019-06-05 10:33:54 -0700 (Wed, 05 Jun 2019)

Log Message

REGRESSION (~r244378) fast/events/touch/ios/content-observation/stuck-with-hover-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=198571
<rdar://problem/50349265>

Reviewed by Brent Fulgham.

testRunner.notifyDone() is called prematurely.

* fast/events/touch/ios/content-observation/stuck-with-hover-state.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (246112 => 246113)


--- trunk/LayoutTests/ChangeLog	2019-06-05 17:03:27 UTC (rev 246112)
+++ trunk/LayoutTests/ChangeLog	2019-06-05 17:33:54 UTC (rev 246113)
@@ -1,3 +1,15 @@
+2019-06-05  Zalan Bujtas  <za...@apple.com>
+
+        REGRESSION (~r244378) fast/events/touch/ios/content-observation/stuck-with-hover-state.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=198571
+        <rdar://problem/50349265>
+
+        Reviewed by Brent Fulgham.
+
+        testRunner.notifyDone() is called prematurely.
+
+        * fast/events/touch/ios/content-observation/stuck-with-hover-state.html:
+
 2019-06-05  Shawn Roberts  <srobe...@apple.com>
 
         http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html is a flaky failure on Mojave

Modified: trunk/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html (246112 => 246113)


--- trunk/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html	2019-06-05 17:03:27 UTC (rev 246112)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html	2019-06-05 17:33:54 UTC (rev 246113)
@@ -24,9 +24,7 @@
     let x = rect.left + rect.width / 2;
     let y = rect.top + rect.height / 2;
 
-	await tapAtPoint(x, y);
-
-    setTimeout("testRunner.notifyDone()", 50);
+    await tapAtPoint(x, y);
 }
 </script>
 </head>
@@ -35,11 +33,13 @@
 <pre id=result></pre>
 <script>
 tapthis.addEventListener("mouseover", function( event ) {
-	clearTimeout(setTimeout(function() { tapthis.innerHTML = "should not see this"; }, 50));
+    clearTimeout(setTimeout(function() { tapthis.innerHTML = "should not see this"; }, 50));
 }, false);
 
 tapthis.addEventListener("click", function( event ) {   
-	result.innerHTML = "clicked";
+    result.innerHTML = "clicked";
+    if (window.testRunner)
+        testRunner.notifyDone();
 }, false);
 </script>
 </body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to