Title: [246312] trunk
- Revision
- 246312
- Author
- [email protected]
- Date
- 2019-06-11 08:13:59 -0700 (Tue, 11 Jun 2019)
Log Message
MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
https://bugs.webkit.org/show_bug.cgi?id=198740
<rdar://problem/47088939>
Reviewed by Eric Carlson.
Source/WebCore:
Covered by tests that are now passing.
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (246311 => 246312)
--- trunk/LayoutTests/ChangeLog 2019-06-11 14:46:23 UTC (rev 246311)
+++ trunk/LayoutTests/ChangeLog 2019-06-11 15:13:59 UTC (rev 246312)
@@ -1,3 +1,13 @@
+2019-06-11 Youenn Fablet <[email protected]>
+
+ MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
+ https://bugs.webkit.org/show_bug.cgi?id=198740
+ <rdar://problem/47088939>
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac/TestExpectations:
+
2019-06-11 Fujii Hironori <[email protected]>
[cairo][SVG] Putting multiple path elements in clippath causes rendering artifacts
Modified: trunk/LayoutTests/platform/mac/TestExpectations (246311 => 246312)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-06-11 14:46:23 UTC (rev 246311)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-06-11 15:13:59 UTC (rev 246312)
@@ -1932,12 +1932,6 @@
[ Mojave+ ] webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html [ Failure ]
# <rdar://problem/47088939>
-[ Mojave+ ] webrtc/audio-peer-connection-webaudio.html [ Failure ]
-[ Mojave+ ] webrtc/audio-replace-track.html [ Failure ]
[ Mojave+ ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html [ Failure ]
-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute.html [ Skip ]
-[ Mojave+ ] webrtc/peer-connection-audio-mute2.html [ Failure ]
-[ Mojave+ ] webrtc/peer-connection-audio-mute.html [ Skip ]
-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute2.html [ Pass Failure ]
[ Mojave+ ] webaudio/realtimeanalyser-fft-scaling.html [ Pass Failure ]
[ Mojave+ ] webaudio/oscillator-sine.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (246311 => 246312)
--- trunk/Source/WebCore/ChangeLog 2019-06-11 14:46:23 UTC (rev 246311)
+++ trunk/Source/WebCore/ChangeLog 2019-06-11 15:13:59 UTC (rev 246312)
@@ -1,3 +1,16 @@
+2019-06-11 Youenn Fablet <[email protected]>
+
+ MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
+ https://bugs.webkit.org/show_bug.cgi?id=198740
+ <rdar://problem/47088939>
+
+ Reviewed by Eric Carlson.
+
+ Covered by tests that are now passing.
+
+ * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
+ (WebCore::MediaStreamAudioSourceNode::setFormat):
+
2019-06-11 Ludovico de Nittis <[email protected]>
[GTK] Replace gdk_screen_get_monitor_geometry and gdk_screen_get_monitor_workarea
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp (246311 => 246312)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp 2019-06-11 14:46:23 UTC (rev 246311)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp 2019-06-11 15:13:59 UTC (rev 246312)
@@ -72,7 +72,7 @@
void MediaStreamAudioSourceNode::setFormat(size_t numberOfChannels, float sourceSampleRate)
{
float sampleRate = this->sampleRate();
- if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == sampleRate)
+ if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == m_sourceSampleRate)
return;
// The sample-rate must be equal to the context's sample-rate.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
