Skip to site navigation (Press enter)

[webkit-changes] [246370] trunk/Source/WebKit

bfulgham Wed, 12 Jun 2019 12:54:32 -0700

Title: [246370] trunk/Source/WebKit

Revision: 246370
Author: [email protected]
Date: 2019-06-12 12:52:48 -0700 (Wed, 12 Jun 2019)

Log Message

Unreviewed fix after r246360.


Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm

Diff

Modified: trunk/Source/WebKit/ChangeLog (246369 => 246370)


--- trunk/Source/WebKit/ChangeLog	2019-06-12 19:06:16 UTC (rev 246369)
+++ trunk/Source/WebKit/ChangeLog	2019-06-12 19:52:48 UTC (rev 246370)
@@ -1,3 +1,12 @@
+2019-06-12  Brent Fulgham  <[email protected]>
+
+        Unreviewed fix after rr246360.
+
+        The current code accidentally calls the completion handler twice.
+
+        * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+        (-[WKWebsiteDataStore _setPrevalentDomain:completionHandler:]):
+
 2019-06-12  Jiewen Tan  <[email protected]>
 
         REGRESSION (r245043) [Mac WK2 Debug] ASSERTION FAILED: m_services.isEmpty() && transports.size() <= maxTransportNumber seen with two http/wpt/webauthn/public-key-credential-* tests

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm (246369 => 246370)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm	2019-06-12 19:06:16 UTC (rev 246369)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm	2019-06-12 19:52:48 UTC (rev 246370)
@@ -486,8 +486,9 @@
     _websiteDataStore->websiteDataStore().setPrevalentResource(URL(domain), [completionHandler = makeBlockPtr(completionHandler)]() {
         completionHandler();
     });
+#else
+    completionHandler();
 #endif
-    completionHandler();
 }
 
 - (void)_getIsPrevalentDomain:(NSURL *)domain completionHandler:(void (^)(BOOL))completionHandler

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes