Title: [246439] trunk/Source/WebCore
- Revision
- 246439
- Author
- [email protected]
- Date
- 2019-06-14 11:59:18 -0700 (Fri, 14 Jun 2019)
Log Message
Unreviewed. Follow up to r246438. This removes a debug assert until
we do further compiler work in: https://bugs.webkit.org/show_bug.cgi?id=198861
* Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
(WebCore::WHLSL::checkDuplicateFunctions):
* Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (246438 => 246439)
--- trunk/Source/WebCore/ChangeLog 2019-06-14 18:01:05 UTC (rev 246438)
+++ trunk/Source/WebCore/ChangeLog 2019-06-14 18:59:18 UTC (rev 246439)
@@ -1,5 +1,14 @@
2019-06-14 Saam Barati <[email protected]>
+ Unreviewed. Follow up to r246438. This removes a debug assert until
+ we do further compiler work in: https://bugs.webkit.org/show_bug.cgi?id=198861
+
+ * Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
+ (WebCore::WHLSL::checkDuplicateFunctions):
+ * Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
+
+2019-06-14 Saam Barati <[email protected]>
+
[WHLSL] Implement out-of-bounds and nullptr behavior
https://bugs.webkit.org/show_bug.cgi?id=198600
<rdar://problem/51668853>
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp (246438 => 246439)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp 2019-06-14 18:01:05 UTC (rev 246438)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp 2019-06-14 18:59:18 UTC (rev 246439)
@@ -166,7 +166,11 @@
//
// Since we do that, we just need to make sure no native function is a duplicate
// of a user-defined function.
- ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
+
+ // FIXME: Add back this assert once we begin to auto generate these in the compiler
+ // instead of having them in the stdlib
+ // https://bugs.webkit.org/show_bug.cgi?id=198861
+ // ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
if (functions.contains(DuplicateFunctionKey { nativeFunctionDeclaration.get() }))
return false;
}
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt (246438 => 246439)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt 2019-06-14 18:01:05 UTC (rev 246438)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt 2019-06-14 18:59:18 UTC (rev 246439)
@@ -441,9 +441,12 @@
native bool operator<(float, float);
native bool operator==(float, float);
native bool operator==(int, int);
-native bool operator==(thread int*, thread int*);
native float operator*(float, float);
+// FIXME: These should be auto generated by the compiler.
+// https://bugs.webkit.org/show_bug.cgi?id=198861
+native bool operator==(thread int*, thread int*);
+
native bool operator.x(bool2);
native bool operator.y(bool2);
native bool operator.x(bool3);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
