Title: [246551] trunk/Source/WebKit
- Revision
- 246551
- Author
- david_ques...@apple.com
- Date
- 2019-06-18 10:51:05 -0700 (Tue, 18 Jun 2019)
Log Message
Network process crash in SandboxExtension::consume() via Download::publishProgress
https://bugs.webkit.org/show_bug.cgi?id=198968
rdar://problem/51732997
Reviewed by Alex Christensen.
Add an early return if the network process fails to resolve a sandbox extension handle for publishing
progress on a download. Creating the NSProgress doesn't do much since the progress reporting service
won't honor the attempt to publish progress on a URL the process does not have access to, and nothing
else in the Network process makes any use of the progress.
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::publishProgress):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (246550 => 246551)
--- trunk/Source/WebKit/ChangeLog 2019-06-18 17:49:07 UTC (rev 246550)
+++ trunk/Source/WebKit/ChangeLog 2019-06-18 17:51:05 UTC (rev 246551)
@@ -1,3 +1,19 @@
+2019-06-18 David Quesada <david_ques...@apple.com>
+
+ Network process crash in SandboxExtension::consume() via Download::publishProgress
+ https://bugs.webkit.org/show_bug.cgi?id=198968
+ rdar://problem/51732997
+
+ Reviewed by Alex Christensen.
+
+ Add an early return if the network process fails to resolve a sandbox extension handle for publishing
+ progress on a download. Creating the NSProgress doesn't do much since the progress reporting service
+ won't honor the attempt to publish progress on a URL the process does not have access to, and nothing
+ else in the Network process makes any use of the progress.
+
+ * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
+ (WebKit::Download::publishProgress):
+
2019-06-18 Adrian Perez de Castro <ape...@igalia.com>
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.25.1 release
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm (246550 => 246551)
--- trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-06-18 17:49:07 UTC (rev 246550)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-06-18 17:51:05 UTC (rev 246551)
@@ -108,6 +108,8 @@
auto sandboxExtension = SandboxExtension::create(WTFMove(sandboxExtensionHandle));
ASSERT(sandboxExtension);
+ if (!sandboxExtension)
+ return;
m_progress = adoptNS([[WKDownloadProgress alloc] initWithDownloadTask:m_downloadTask.get() download:this URL:(NSURL *)url sandboxExtension:sandboxExtension]);
#if USE(NSPROGRESS_PUBLISHING_SPI)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
