Title: [246558] trunk/Source/WebInspectorUI
- Revision
- 246558
- Author
- drou...@apple.com
- Date
- 2019-06-18 12:33:41 -0700 (Tue, 18 Jun 2019)
Log Message
Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
https://bugs.webkit.org/show_bug.cgi?id=198941
Reviewed by Joseph Pecoraro.
Since heap snapshot records can be added at any time, including when not actively recording,
when the "Entire Recording" range is selected, make sure to set the `filterEndTime` to be an
effectively infinite number so that records added later aren't filtered out.
This isn't done for other timeline views as they may have graphs that don't expect to render
from time 0 till infinity, not to mention being unable to add records when not recording.
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (246557 => 246558)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-06-18 19:13:40 UTC (rev 246557)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-06-18 19:33:41 UTC (rev 246558)
@@ -1,5 +1,22 @@
2019-06-18 Devin Rousso <drou...@apple.com>
+ Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
+ https://bugs.webkit.org/show_bug.cgi?id=198941
+
+ Reviewed by Joseph Pecoraro.
+
+ Since heap snapshot records can be added at any time, including when not actively recording,
+ when the "Entire Recording" range is selected, make sure to set the `filterEndTime` to be an
+ effectively infinite number so that records added later aren't filtered out.
+
+ This isn't done for other timeline views as they may have graphs that don't expect to render
+ from time 0 till infinity, not to mention being unable to add records when not recording.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
+
+2019-06-18 Devin Rousso <drou...@apple.com>
+
Web Inspector: REGRESSION: Canvas: cannot select saved recordings
https://bugs.webkit.org/show_bug.cgi?id=198953
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (246557 => 246558)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-06-18 19:13:40 UTC (rev 246557)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-06-18 19:33:41 UTC (rev 246558)
@@ -836,8 +836,13 @@
let endTime = this._timelineOverview.selectionStartTime + this._timelineOverview.selectionDuration;
if (entireRangeSelected) {
- if (timelineView instanceof WI.RenderingFrameTimelineView) {
+ if (timelineView instanceof WI.RenderingFrameTimelineView)
endTime = this._renderingFrameTimeline.records.length;
+ else if (timelineView instanceof WI.HeapAllocationsTimelineView) {
+ // Since heap snapshots can be added at any time, including when not actively recording,
+ // make sure to set the end time to an effectively infinite number so any new records
+ // that are added in the future aren't filtered out.
+ endTime = Number.MAX_VALUE;
} else {
// Clamp selection to the end of the recording (with padding),
// so graph views will show an auto-sized graph without a lot of
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
