Title: [247384] trunk/Source/WebCore
- Revision
- 247384
- Author
- ape...@igalia.com
- Date
- 2019-07-12 03:08:57 -0700 (Fri, 12 Jul 2019)
Log Message
[ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
https://bugs.webkit.org/show_bug.cgi?id=199748
<rdar://problem/52995908>
Reviewed by Konstantin Tokarev.
No new tests needed.
* accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(listObjectForCoreSelection): Renamed from listObjectForSelection() and remove the
unneeded call to core() now that coreSelection is passed directly to the function.
(optionFromList): Change to pass coreSelection directly to listObjectForCoreSelection().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (247383 => 247384)
--- trunk/Source/WebCore/ChangeLog 2019-07-12 04:36:59 UTC (rev 247383)
+++ trunk/Source/WebCore/ChangeLog 2019-07-12 10:08:57 UTC (rev 247384)
@@ -1,3 +1,18 @@
+2019-07-12 Adrian Perez de Castro <ape...@igalia.com>
+
+ [ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
+ https://bugs.webkit.org/show_bug.cgi?id=199748
+ <rdar://problem/52995908>
+
+ Reviewed by Konstantin Tokarev.
+
+ No new tests needed.
+
+ * accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
+ (listObjectForCoreSelection): Renamed from listObjectForSelection() and remove the
+ unneeded call to core() now that coreSelection is passed directly to the function.
+ (optionFromList): Change to pass coreSelection directly to listObjectForCoreSelection().
+
2019-07-11 Chris Dumez <cdu...@apple.com>
Fix non-thread safe use of makeWeakPtr() under MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify()
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp (247383 => 247384)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp 2019-07-12 04:36:59 UTC (rev 247383)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp 2019-07-12 10:08:57 UTC (rev 247384)
@@ -50,10 +50,8 @@
return &webkitAccessibleGetAccessibilityObject(WEBKIT_ACCESSIBLE(selection));
}
-static AccessibilityObject* listObjectForSelection(AtkSelection* selection)
+static AccessibilityObject* listObjectForCoreSelection(AccessibilityObject* coreSelection)
{
- AccessibilityObject* coreSelection = core(selection);
-
// Only list boxes and menu lists supported so far.
if (!coreSelection->isListBox() && !coreSelection->isMenuList())
return nullptr;
@@ -83,7 +81,7 @@
return nullptr;
// Need to select the proper list object depending on the type.
- AccessibilityObject* listObject = listObjectForSelection(selection);
+ AccessibilityObject* listObject = listObjectForCoreSelection(coreSelection);
if (!listObject)
return nullptr;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
