Diff
Modified: trunk/LayoutTests/ChangeLog (247387 => 247388)
--- trunk/LayoutTests/ChangeLog 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/ChangeLog 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,3 +1,28 @@
+2019-07-12 Timothy Hatcher <timo...@apple.com>
+
+ Drop DarkModeCSSEnabled as an experimental feature and always enable it.
+ https://bugs.webkit.org/show_bug.cgi?id=199725
+ rdar://problem/52970972
+
+ Reviewed by Megan Gardner.
+
+ Removed <!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
+ from all dark mode tests.
+
+ * css-dark-mode/color-scheme-css-parse.html:
+ * css-dark-mode/color-scheme-css.html:
+ * css-dark-mode/color-scheme-meta.html:
+ * css-dark-mode/color-scheme-priority.html:
+ * css-dark-mode/color-scheme-scrollbar.html:
+ * css-dark-mode/default-colors.html:
+ * css-dark-mode/older-syntax/supported-color-schemes-css.html:
+ * css-dark-mode/older-syntax/supported-color-schemes-meta.html:
+ * css-dark-mode/older-systems/color-scheme-css.html:
+ * css-dark-mode/older-systems/color-scheme-meta.html:
+ * css-dark-mode/older-systems/prefers-color-scheme.html:
+ * css-dark-mode/prefers-color-scheme-picture-element.html:
+ * css-dark-mode/prefers-color-scheme.html:
+
2019-07-11 Myles C. Maxfield <mmaxfi...@apple.com>
New York font erroneously gets synthetic bold
Modified: trunk/LayoutTests/css-dark-mode/color-scheme-css-parse.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/color-scheme-css-parse.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/color-scheme-css-parse.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/color-scheme-css.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/color-scheme-css.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/color-scheme-css.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/color-scheme-meta.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/color-scheme-meta.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/color-scheme-meta.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/color-scheme-priority.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/color-scheme-priority.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/color-scheme-priority.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/color-scheme-scrollbar.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/color-scheme-scrollbar.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/color-scheme-scrollbar.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/default-colors.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/default-colors.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/default-colors.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-meta.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-meta.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-meta.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-css.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-css.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-css.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-meta.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-meta.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/older-systems/color-scheme-meta.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/older-systems/prefers-color-scheme.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/older-systems/prefers-color-scheme.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/older-systems/prefers-color-scheme.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/prefers-color-scheme-picture-element.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/prefers-color-scheme-picture-element.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/prefers-color-scheme-picture-element.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html (247387 => 247388)
--- trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,7 +1,5 @@
<!DOCTYPE html>
-<!-- webkit-test-runner [ experimental:DarkModeCSSEnabled=true ] -->
-
<script src=""
<script src=""
Modified: trunk/Source/WebCore/ChangeLog (247387 => 247388)
--- trunk/Source/WebCore/ChangeLog 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/ChangeLog 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,3 +1,28 @@
+2019-07-12 Timothy Hatcher <timo...@apple.com>
+
+ Drop DarkModeCSSEnabled as an experimental feature and always enable it.
+ https://bugs.webkit.org/show_bug.cgi?id=199725
+ rdar://problem/52970972
+
+ Reviewed by Megan Gardner.
+
+ Tests: css-dark-mode
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::prefersColorSchemeEvaluate):
+ * css/MediaQueryExpression.cpp:
+ (WebCore::featureWithValidIdent):
+ (WebCore::isFeatureValidWithoutValue):
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::CSSPropertyParser::parseSingleValue):
+ * html/HTMLMetaElement.cpp:
+ (WebCore::HTMLMetaElement::process):
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setDarkModeCSSEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::darkModeCSSEnabled const): Deleted.
+
2019-07-12 Carlos Alberto Lopez Perez <clo...@igalia.com>
Refactor ShadowBlur: remove some class variables and use function parameters instead.
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (247387 => 247388)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2019-07-12 15:19:06 UTC (rev 247388)
@@ -4029,9 +4029,6 @@
#if ENABLE(DARK_MODE_CSS)
case CSSPropertyColorScheme: {
- if (!RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled())
- return nullptr;
-
auto colorScheme = style.colorScheme();
if (colorScheme.isAuto())
return cssValuePool.createIdentifierValue(CSSValueAuto);
Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.cpp (247387 => 247388)
--- trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2019-07-12 15:19:06 UTC (rev 247388)
@@ -767,8 +767,6 @@
#if ENABLE(DARK_MODE_CSS)
static bool prefersColorSchemeEvaluate(CSSValue* value, const CSSToLengthConversionData&, Frame& frame, MediaFeaturePrefix)
{
- ASSERT(RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled());
-
if (!value)
return true;
Modified: trunk/Source/WebCore/css/MediaQueryExpression.cpp (247387 => 247388)
--- trunk/Source/WebCore/css/MediaQueryExpression.cpp 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/css/MediaQueryExpression.cpp 2019-07-12 15:19:06 UTC (rev 247388)
@@ -55,7 +55,7 @@
|| mediaFeature == MediaFeatureNames::displayMode
#endif
#if ENABLE(DARK_MODE_CSS)
- || (mediaFeature == MediaFeatureNames::prefersColorScheme && RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled())
+ || (mediaFeature == MediaFeatureNames::prefersColorScheme)
#endif
|| mediaFeature == MediaFeatureNames::prefersReducedMotion
|| (mediaFeature == MediaFeatureNames::prefersDarkInterface && (context.useSystemAppearance || isUASheetBehavior(context.mode)));
@@ -168,7 +168,7 @@
|| mediaFeature == MediaFeatureNames::prefersReducedMotion
|| (mediaFeature == MediaFeatureNames::prefersDarkInterface && (context.useSystemAppearance || isUASheetBehavior(context.mode)))
#if ENABLE(DARK_MODE_CSS)
- || (mediaFeature == MediaFeatureNames::prefersColorScheme && RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled())
+ || (mediaFeature == MediaFeatureNames::prefersColorScheme)
#endif
|| mediaFeature == MediaFeatureNames::devicePixelRatio
|| mediaFeature == MediaFeatureNames::resolution
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (247387 => 247388)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2019-07-12 15:19:06 UTC (rev 247388)
@@ -4241,8 +4241,6 @@
return consumeTextEmphasisPosition(m_range);
#if ENABLE(DARK_MODE_CSS)
case CSSPropertyColorScheme:
- if (!RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled())
- return nullptr;
return consumeColorScheme(m_range);
#endif
default:
Modified: trunk/Source/WebCore/html/HTMLMetaElement.cpp (247387 => 247388)
--- trunk/Source/WebCore/html/HTMLMetaElement.cpp 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/html/HTMLMetaElement.cpp 2019-07-12 15:19:06 UTC (rev 247388)
@@ -92,7 +92,7 @@
else if (RuntimeEnabledFeatures::sharedFeatures().disabledAdaptationsMetaTagEnabled() && equalLettersIgnoringASCIICase(name(), "disabled-adaptations"))
document().processDisabledAdaptations(contentValue);
#if ENABLE(DARK_MODE_CSS)
- else if (RuntimeEnabledFeatures::sharedFeatures().darkModeCSSEnabled() && (equalLettersIgnoringASCIICase(name(), "color-scheme") || equalLettersIgnoringASCIICase(name(), "supported-color-schemes")))
+ else if (equalLettersIgnoringASCIICase(name(), "color-scheme") || equalLettersIgnoringASCIICase(name(), "supported-color-schemes"))
document().processColorScheme(contentValue);
#endif
#if PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (247387 => 247388)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2019-07-12 15:19:06 UTC (rev 247388)
@@ -85,11 +85,6 @@
void setDirectoryUploadEnabled(bool isEnabled) { m_isDirectoryUploadEnabled = isEnabled; }
bool directoryUploadEnabled() const { return m_isDirectoryUploadEnabled; }
-#if ENABLE(DARK_MODE_CSS)
- void setDarkModeCSSEnabled(bool isEnabled) { m_isDarkModeCSSEnabled = isEnabled; }
- bool darkModeCSSEnabled() const { return m_isDarkModeCSSEnabled; }
-#endif
-
void setDataTransferItemsEnabled(bool areEnabled) { m_areDataTransferItemsEnabled = areEnabled; }
bool dataTransferItemsEnabled() const { return m_areDataTransferItemsEnabled; }
@@ -437,10 +432,6 @@
bool m_isAttachmentElementEnabled { false };
#endif
-#if ENABLE(DARK_MODE_CSS)
- bool m_isDarkModeCSSEnabled { true };
-#endif
-
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
bool m_isIndexedDBWorkersEnabled { true };
#endif
Modified: trunk/Source/WebKit/ChangeLog (247387 => 247388)
--- trunk/Source/WebKit/ChangeLog 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebKit/ChangeLog 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1,3 +1,13 @@
+2019-07-12 Timothy Hatcher <timo...@apple.com>
+
+ Drop DarkModeCSSEnabled as an experimental feature and always enable it.
+ https://bugs.webkit.org/show_bug.cgi?id=199725
+ rdar://problem/52970972
+
+ Reviewed by Megan Gardner.
+
+ * Shared/WebPreferences.yaml: Removed DarkModeCSSEnabled.
+
2019-07-11 Myles C. Maxfield <mmaxfi...@apple.com>
New York font erroneously gets synthetic bold
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (247387 => 247388)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-07-12 14:47:36 UTC (rev 247387)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-07-12 15:19:06 UTC (rev 247388)
@@ -1354,15 +1354,6 @@
webcoreBinding: RuntimeEnabledFeatures
category: experimental
-DarkModeCSSEnabled:
- type: bool
- defaultValue: true
- humanReadableName: "Dark Mode CSS Support"
- humanReadableDescription: "Enable Dark Mode CSS Support"
- webcoreBinding: RuntimeEnabledFeatures
- category: experimental
- condition: ENABLE(DARK_MODE_CSS)
-
CSSPaintingAPIEnabled:
type: bool
defaultValue: false
