Title: [248007] trunk/Websites/perf.webkit.org
- Revision
- 248007
- Author
- dewei_...@apple.com
- Date
- 2019-07-30 09:04:23 -0700 (Tue, 30 Jul 2019)
Log Message
Should not render latest build information if there is no data points for a config.
https://bugs.webkit.org/show_bug.cgi?id=200250
Reviewed by Ryosuke Niwa.
Fix a bug test freshness page that tooltip cannot be rendered when a cell does not have
a data point.
* public/v3/pages/test-freshness-page.js: Added a null check on commit set before rendering
latest build informaiton.
(TestFreshnessPage.prototype._renderTooltip):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (248006 => 248007)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-07-30 15:40:01 UTC (rev 248006)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-07-30 16:04:23 UTC (rev 248007)
@@ -1,3 +1,17 @@
+2019-07-29 Dewei Zhu <dewei_...@apple.com>
+
+ Should not render latest build information if there is no data points for a config.
+ https://bugs.webkit.org/show_bug.cgi?id=200250
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix a bug test freshness page that tooltip cannot be rendered when a cell does not have
+ a data point.
+
+ * public/v3/pages/test-freshness-page.js: Added a null check on commit set before rendering
+ latest build informaiton.
+ (TestFreshnessPage.prototype._renderTooltip):
+
2019-07-25 Dewei Zhu <dewei_...@apple.com>
Fix a bug that cannot update builder password on builders administrative page.
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (248006 => 248007)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-07-30 15:40:01 UTC (rev 248006)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-07-30 16:04:23 UTC (rev 248007)
@@ -171,17 +171,20 @@
tooltipTable.style.left = rect.left + rect.width / 2 - tooltipTable.offsetWidth / 2 + containerMarginLeft + 'px';
let tableContent = [element('tr', element('td', {colspan: 2}, buildSummary))];
- if (commitSet.repositories().length)
- tableContent.push(element('tr', element('th', {colspan: 2}, 'Latest build information')));
- tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.repositories()).map((repository) => {
- const commit = commitSet.commitForRepository(repository);
- return element('tr', [
- element('td', repository.name()),
- element('td', commit.url() ? link(commit.label(), commit.label(), commit.url(), true) : commit.label())
- ]);
- }));
+ if (commitSet) {
+ if (commitSet.repositories().length)
+ tableContent.push(element('tr', element('th', {colspan: 2}, 'Latest build information')));
+ tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.repositories()).map((repository) => {
+ const commit = commitSet.commitForRepository(repository);
+ return element('tr', [
+ element('td', repository.name()),
+ element('td', commit.url() ? link(commit.label(), commit.label(), commit.url(), true) : commit.label())
+ ]);
+ }));
+ }
+
if (build) {
const url = ""
const buildNumber = build.buildNumber();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
