[webkit-changes] [248083] trunk/Source/WebCore

Wed, 31 Jul 2019 17:05:51 -0700

Title: [248083] trunk/Source/WebCore
Revision
248083
Author
sbar...@apple.com
Date
2019-07-31 17:04:23 -0700 (Wed, 31 Jul 2019)

Log Message

[WHLSL] Remove UnnamedType copy/move constructors and mark classes as final
https://bugs.webkit.org/show_bug.cgi?id=200188
<rdar://problem/53628171>

Unreviewed followup.

As Darin pointed out in the bugzilla comments, when defining a copy
constructor in C++ (either deleted or an implementation), the move
constructor is implicitly deleted. This match removes the excessive
use of WTF_MAKE_NONMOVABLE when we're already using WTF_MAKE_NONCOPYABLE.

* Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
* Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
* Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
* Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (248082 => 248083)


--- trunk/Source/WebCore/ChangeLog	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/ChangeLog	2019-08-01 00:04:23 UTC (rev 248083)
@@ -1,3 +1,23 @@
+2019-07-31  Saam Barati  <sbar...@apple.com>
+
+        [WHLSL] Remove UnnamedType copy/move constructors and mark classes as final
+        https://bugs.webkit.org/show_bug.cgi?id=200188
+        <rdar://problem/53628171>
+
+        Unreviewed followup.
+
+        As Darin pointed out in the bugzilla comments, when defining a copy
+        constructor in C++ (either deleted or an implementation), the move
+        constructor is implicitly deleted. This match removes the excessive
+        use of WTF_MAKE_NONMOVABLE when we're already using WTF_MAKE_NONCOPYABLE.
+
+        * Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
+        * Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
+        * Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
+        * Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
+        * Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
+        * Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
+
 2019-07-31  Zalan Bujtas  <za...@apple.com>
 
         [ContentChangeObserver] twitch.tv video controls do not always respond to taps in fullscreen

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -31,7 +31,6 @@
 #include "WHLSLReferenceType.h"
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/Nonmovable.h>
 #include <wtf/UniqueRef.h>
 #include <wtf/text/WTFString.h>
 
@@ -44,7 +43,6 @@
 class ArrayReferenceType : public ReferenceType {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(ArrayReferenceType);
-    WTF_MAKE_NONMOVABLE(ArrayReferenceType);
     using Base = ReferenceType;
 
     ArrayReferenceType(CodeLocation location, AddressSpace addressSpace, Ref<UnnamedType> elementType)

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -32,7 +32,6 @@
 #include "WHLSLUnnamedType.h"
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/Nonmovable.h>
 #include <wtf/UniqueRef.h>
 #include <wtf/text/WTFString.h>
 
@@ -45,7 +44,6 @@
 class ArrayType final : public UnnamedType {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(ArrayType);
-    WTF_MAKE_NONMOVABLE(ArrayType);
     ArrayType(CodeLocation location, Ref<UnnamedType> elementType, unsigned numElements)
         : UnnamedType(location)
         , m_elementType(WTFMove(elementType))

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -31,7 +31,6 @@
 #include "WHLSLReferenceType.h"
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/Nonmovable.h>
 #include <wtf/UniqueRef.h>
 #include <wtf/text/WTFString.h>
 
@@ -44,7 +43,6 @@
 class PointerType final : public ReferenceType {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(PointerType);
-    WTF_MAKE_NONMOVABLE(PointerType);
     using Base = ReferenceType;
 
     PointerType(CodeLocation location, AddressSpace addressSpace, Ref<UnnamedType> elementType)

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -43,7 +43,6 @@
 class ReferenceType : public UnnamedType {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(ReferenceType);
-    WTF_MAKE_NONMOVABLE(ReferenceType);
 protected:
     ReferenceType(CodeLocation location, AddressSpace addressSpace, Ref<UnnamedType> elementType)
         : UnnamedType(location)

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -33,7 +33,6 @@
 #include "WHLSLUnnamedType.h"
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/Nonmovable.h>
 #include <wtf/UniqueRef.h>
 #include <wtf/text/WTFString.h>
 
@@ -48,7 +47,6 @@
 class TypeReference final : public UnnamedType {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(TypeReference);
-    WTF_MAKE_NONMOVABLE(TypeReference);
     TypeReference(CodeLocation location, String&& name, TypeArguments&& typeArguments)
         : UnnamedType(location)
         , m_name(WTFMove(name))

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h (248082 => 248083)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h	2019-07-31 23:34:14 UTC (rev 248082)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h	2019-08-01 00:04:23 UTC (rev 248083)
@@ -31,7 +31,6 @@
 #include "WHLSLType.h"
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/Nonmovable.h>
 #include <wtf/RefCounted.h>
 #include <wtf/UniqueRef.h>
 #include <wtf/text/WTFString.h>
@@ -45,7 +44,6 @@
 class UnnamedType : public Type, public RefCounted<UnnamedType> {
     WTF_MAKE_FAST_ALLOCATED;
     WTF_MAKE_NONCOPYABLE(UnnamedType);
-    WTF_MAKE_NONMOVABLE(UnnamedType);
 public:
     UnnamedType(CodeLocation location)
         : m_codeLocation(location)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to