Title: [248117] trunk/Tools
- Revision
- 248117
- Author
- commit-qu...@webkit.org
- Date
- 2019-08-01 12:43:02 -0700 (Thu, 01 Aug 2019)
Log Message
results.webkit.org: Collision detection for dots is off by 2 * dotMargin
https://bugs.webkit.org/show_bug.cgi?id=200347
Patch by Zhifei Fang <zhifei_f...@apple.com> on 2019-08-01
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (248116 => 248117)
--- trunk/Tools/ChangeLog 2019-08-01 19:32:59 UTC (rev 248116)
+++ trunk/Tools/ChangeLog 2019-08-01 19:43:02 UTC (rev 248117)
@@ -1,3 +1,13 @@
+2019-08-01 Zhifei Fang <zhifei_f...@apple.com>
+
+ results.webkit.org: Collision detection for dots is off by 2 * dotMargin
+ https://bugs.webkit.org/show_bug.cgi?id=200347
+
+ Reviewed by Jonathan Bedard.
+
+ * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+ (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
+
2019-08-01 Jiewen Tan <jiewen_...@apple.com>
Improve flakiness of SOAuthorizationRedirect tests
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (248116 => 248117)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-01 19:32:59 UTC (rev 248116)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2019-08-01 19:43:02 UTC (rev 248117)
@@ -322,7 +322,7 @@
let x = i * dotWidth - (scrollLeft < padding ? scrollLeft : scrollLeft - padding);
if (currentDotIndex < dots.length && comp(scales[i], getScale(dots[currentDotIndex])) === 0) {
render(dots[currentDotIndex], context, x, radius);
- dots[currentDotIndex]._dotCenter = {x: x + 3 * radius, y: radius};
+ dots[currentDotIndex]._dotCenter = {x: x + dotMargin + radius, y: radius};
dots[currentDotIndex]._cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
inCacheDots.push(dots[currentDotIndex]);
currentDotIndex += 1;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
