Modified: trunk/Source/_javascript_Core/ChangeLog (248132 => 248133)
--- trunk/Source/_javascript_Core/ChangeLog 2019-08-01 20:35:15 UTC (rev 248132)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-08-01 21:30:39 UTC (rev 248133)
@@ -1,3 +1,17 @@
+2019-08-01 Keith Miller <keith_mil...@apple.com>
+
+ Fix bug in testMulImm32SignExtend
+ https://bugs.webkit.org/show_bug.cgi?id=200358
+
+ Reviewed by Mark Lam.
+
+ Also, have it run in more configurations.
+
+ * b3/testb3_2.cpp:
+ (testMulImm32SignExtend):
+ * b3/testb3_3.cpp:
+ (addArgTests):
+
2019-07-31 Mark Lam <mark....@apple.com>
Rename DOMJIT safe/unsafeFunction to functionWithTypeChecks and functionWithoutTypeChecks.
Modified: trunk/Source/_javascript_Core/b3/testb3_2.cpp (248132 => 248133)
--- trunk/Source/_javascript_Core/b3/testb3_2.cpp 2019-08-01 20:35:15 UTC (rev 248132)
+++ trunk/Source/_javascript_Core/b3/testb3_2.cpp 2019-08-01 21:30:39 UTC (rev 248133)
@@ -961,7 +961,7 @@
Value* arg1 = root->appendNew<Const64Value>(proc, Origin(), a);
Value* arg2 = root->appendNew<Value>(
proc, Trunc, Origin(),
- root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR1));
+ root->appendNew<ArgumentRegValue>(proc, Origin(), GPRInfo::argumentGPR0));
Value* arg264 = root->appendNew<Value>(proc, SExt32, Origin(), arg2);
Value* mul = root->appendNew<Value>(proc, Mul, Origin(), arg1, arg264);
root->appendNewControlValue(proc, Return, Origin(), mul);
@@ -968,7 +968,7 @@
auto code = compileProc(proc);
- CHECK(invoke<long int>(*code, b) == ((long int) a) * ((long int) b));
+ CHECK_EQ(invoke<long int>(*code, b), ((long int) a) * ((long int) b));
}
void testMulLoadTwice()
Modified: trunk/Source/_javascript_Core/b3/testb3_3.cpp (248132 => 248133)
--- trunk/Source/_javascript_Core/b3/testb3_3.cpp 2019-08-01 20:35:15 UTC (rev 248132)
+++ trunk/Source/_javascript_Core/b3/testb3_3.cpp 2019-08-01 21:30:39 UTC (rev 248133)
@@ -3104,11 +3104,7 @@
RUN(testMulImmArg(0, 2));
RUN(testMulImmArg(1, 0));
RUN(testMulImmArg(3, 3));
- RUN(testMulImm32SignExtend(1, 2));
- RUN(testMulImm32SignExtend(0, 2));
- RUN(testMulImm32SignExtend(1, 0));
- RUN(testMulImm32SignExtend(3, 3));
- RUN(testMulImm32SignExtend(0xFFFFFFFF, 0xFFFFFFFF));
+ RUN_BINARY(testMulImm32SignExtend, int32Operands(), int32Operands());
RUN(testMulImm32SignExtend(0xFFFFFFFE, 0xFFFFFFFF));
RUN(testMulImm32SignExtend(0xFFFFFFFF, 0xFFFFFFFE));
RUN(testMulArgs32(1, 1));
