Title: [248272] trunk/Tools
- Revision
- 248272
- Author
- aakash_j...@apple.com
- Date
- 2019-08-05 14:24:52 -0700 (Mon, 05 Aug 2019)
Log Message
New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
https://bugs.webkit.org/show_bug.cgi?id=200400
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble):
(StatusBubble._queue_position):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (248271 => 248272)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-08-05 20:02:51 UTC (rev 248271)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-08-05 21:24:52 UTC (rev 248272)
@@ -54,6 +54,7 @@
}
STEPS_TO_HIDE = ['Killed old processes', 'Configured build', '^OS:.*Xcode:', '(skipped)']
+ DAYS_TO_CHECK = 3
def _build_bubble(self, patch, queue):
bubble = {
@@ -83,6 +84,11 @@
bubble['details_message'] = 'Build is in-progress. Recent messages:\n\n' + self._steps_messages(build)
elif build.result == Buildbot.SUCCESS:
if is_parent_build:
+ if patch.modified < (timezone.now() - datetime.timedelta(days=StatusBubble.DAYS_TO_CHECK)):
+ # Do not display bubble for old patch for which no build has been reported on given queue.
+ # Most likely the patch would never be processed on this queue, since either the queue was
+ # added after the patch was submitted, or build request for that patch was cancelled.
+ return None
bubble['state'] = 'started'
bubble['details_message'] = 'Build is in-progress. Recent messages:\n\n' + self._steps_messages(build) + '\n\nWaiting to run tests.'
else:
@@ -194,8 +200,7 @@
def _queue_position(self, patch, queue, parent_queue=None):
# FIXME: Handle retried builds and cancelled build-requests as well.
- DAYS_TO_CHECK = 3
- from_timestamp = timezone.now() - datetime.timedelta(days=DAYS_TO_CHECK)
+ from_timestamp = timezone.now() - datetime.timedelta(days=StatusBubble.DAYS_TO_CHECK)
if patch.modified < from_timestamp:
# Do not display bubble for old patch for which no build has been reported on given queue.
Modified: trunk/Tools/ChangeLog (248271 => 248272)
--- trunk/Tools/ChangeLog 2019-08-05 20:02:51 UTC (rev 248271)
+++ trunk/Tools/ChangeLog 2019-08-05 21:24:52 UTC (rev 248272)
@@ -1,3 +1,14 @@
+2019-08-05 Aakash Jain <aakash_j...@apple.com>
+
+ New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
+ https://bugs.webkit.org/show_bug.cgi?id=200400
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble):
+ (StatusBubble._queue_position):
+
2019-08-05 Jonathan Bedard <jbed...@apple.com>
run-webkit-tests asserts when the iPhone XR simulator is running
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
