Title: [248615] branches/safari-608-branch/Source/WebCore
Revision
248615
Author
alanc...@apple.com
Date
2019-08-13 13:00:56 -0700 (Tue, 13 Aug 2019)

Log Message

Cherry-pick r248295. rdar://problem/54237762

    REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
    https://bugs.webkit.org/show_bug.cgi?id=200466

    Reviewed by Zalan Bujtas.

    The page calls preventDefault() for a mouse event generated by a site specific quirk.

    * page/Quirks.cpp:
    (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

    Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (248614 => 248615)


--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-08-13 20:00:54 UTC (rev 248614)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-08-13 20:00:56 UTC (rev 248615)
@@ -1,5 +1,38 @@
 2019-08-13  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r248295. rdar://problem/54237762
+
+    REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
+    https://bugs.webkit.org/show_bug.cgi?id=200466
+    
+    Reviewed by Zalan Bujtas.
+    
+    The page calls preventDefault() for a mouse event generated by a site specific quirk.
+    
+    * page/Quirks.cpp:
+    (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+    
+    Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-08-06  Antti Koivisto  <an...@apple.com>
+
+            REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
+            https://bugs.webkit.org/show_bug.cgi?id=200466
+
+            Reviewed by Zalan Bujtas.
+
+            The page calls preventDefault() for a mouse event generated by a site specific quirk.
+
+            * page/Quirks.cpp:
+            (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
+            Disable the quirk for the "m." subdomain. This is a mobile site that don't need or expect them.
+
+2019-08-13  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r248292. rdar://problem/54236220
 
     [iPadOS] Unable to increase zoom level on Google using the Aa menu

Modified: branches/safari-608-branch/Source/WebCore/page/Quirks.cpp (248614 => 248615)


--- branches/safari-608-branch/Source/WebCore/page/Quirks.cpp	2019-08-13 20:00:54 UTC (rev 248614)
+++ branches/safari-608-branch/Source/WebCore/page/Quirks.cpp	2019-08-13 20:00:56 UTC (rev 248615)
@@ -319,9 +319,16 @@
         return true;
     if (equalLettersIgnoringASCIICase(host, "naver.com"))
         return true;
-    // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
-    if (host.endsWithIgnoringASCIICase(".naver.com"))
-        return !equalLettersIgnoringASCIICase(host, "tv.naver.com");
+    if (host.endsWithIgnoringASCIICase(".naver.com")) {
+        // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
+        if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
+            return false;
+        // Disable the quirk on the mobile site.
+        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
+        if (equalLettersIgnoringASCIICase(host, "m.naver.com"))
+            return false;
+        return true;
+    }
     return false;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to