Title: [248737] trunk/Source/WebInspectorUI
- Revision
- 248737
- Author
- drou...@apple.com
- Date
- 2019-08-15 12:18:43 -0700 (Thu, 15 Aug 2019)
Log Message
Web Inspector: Sources: the "No Filter Results" message sits on top of all of the content, preventing any interaction
https://bugs.webkit.org/show_bug.cgi?id=200755
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel):
* UserInterface/Views/SourcesNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.sources > .content > .resources-container): Added.
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container)): Added.
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .call-stack-container):
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .breakpoints-container):
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .resources-container): Added.
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources)): Deleted.
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .resources): Deleted.
Wrap the resources `WI.TreeOutline` in a <div> so the empty message placeholder that gets
inserted after it can be constrained to the size of the `WI.TreeOutline`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248736 => 248737)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-15 19:16:04 UTC (rev 248736)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-15 19:18:43 UTC (rev 248737)
@@ -1,5 +1,25 @@
2019-08-15 Devin Rousso <drou...@apple.com>
+ Web Inspector: Sources: the "No Filter Results" message sits on top of all of the content, preventing any interaction
+ https://bugs.webkit.org/show_bug.cgi?id=200755
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+ (WI.SourcesNavigationSidebarPanel):
+ * UserInterface/Views/SourcesNavigationSidebarPanel.css:
+ (.sidebar > .panel.navigation.sources > .content > .resources-container): Added.
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container)): Added.
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .call-stack-container):
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .breakpoints-container):
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .resources-container): Added.
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources)): Deleted.
+ (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > .resources): Deleted.
+ Wrap the resources `WI.TreeOutline` in a <div> so the empty message placeholder that gets
+ inserted after it can be constrained to the size of the `WI.TreeOutline`.
+
+2019-08-15 Devin Rousso <drou...@apple.com>
+
Web Inspector: Layers: background of 3D area doesn't update when transitioning to/from Dark mode
https://bugs.webkit.org/show_bug.cgi?id=200775
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css (248736 => 248737)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2019-08-15 19:16:04 UTC (rev 248736)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2019-08-15 19:18:43 UTC (rev 248737)
@@ -92,6 +92,10 @@
background-color: var(--panel-background-color);
}
+.sidebar > .panel.navigation.sources > .content > .resources-container {
+ position: relative;
+}
+
.sidebar > .panel.navigation.sources > .content .tree-outline.single-thread {
-webkit-margin-start: -10px;
}
@@ -111,9 +115,8 @@
--details-section-header-top: 0;
}
- .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources) {
+ .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container) {
height: 100%;
- max-height: fit-content;
overflow-y: auto;
}
@@ -120,14 +123,16 @@
.sidebar > .panel.navigation.sources > .content > .call-stack-container {
flex-grow: 3;
flex-shrink: 2;
+ max-height: fit-content;
}
.sidebar > .panel.navigation.sources > .content > .breakpoints-container {
flex-grow: 2;
flex-shrink: 3;
+ max-height: fit-content;
}
- .sidebar > .panel.navigation.sources > .content > .resources {
+ .sidebar > .panel.navigation.sources > .content > .resources-container {
flex-grow: 1;
flex-shrink: 3;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js (248736 => 248737)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2019-08-15 19:16:04 UTC (rev 248736)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2019-08-15 19:18:43 UTC (rev 248737)
@@ -233,11 +233,14 @@
WI.addMouseDownContextMenuHandlers(resourceGroupingModeNavigationItem.element, this._populateResourceGroupingModeContextMenu.bind(this));
this._resourcesNavigationBar.addNavigationItem(resourceGroupingModeNavigationItem);
+ let resourcesContainer = document.createElement("div");
+ resourcesContainer.classList.add("resources-container");
+ this.contentView.element.insertBefore(resourcesContainer, this._resourcesNavigationBar.element.nextSibling);
+
this._resourcesTreeOutline = this.contentTreeOutline;
- this._resourcesTreeOutline.element.classList.add("resources");
this._resourcesTreeOutline.addEventListener(WI.TreeOutline.Event.SelectionDidChange, this._handleTreeSelectionDidChange, this);
this._resourcesTreeOutline.includeSourceMapResourceChildren = true;
- this.contentView.element.insertBefore(this._resourcesTreeOutline.element, this._resourcesNavigationBar.element.nextSibling);
+ resourcesContainer.appendChild(this._resourcesTreeOutline.element);
let _onlyShowResourcesWithIssuesFilterFunction_ = (treeElement) => {
if (treeElement.treeOutline !== this._resourcesTreeOutline)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
