Title: [249014] trunk/Source/WebInspectorUI
- Revision
- 249014
- Author
- pecor...@apple.com
- Date
- 2019-08-22 09:42:57 -0700 (Thu, 22 Aug 2019)
Log Message
Web Inspector: Provide an engineering option to log protocol traffic as text
https://bugs.webkit.org/show_bug.cgi?id=200969
Reviewed by Devin Rousso.
* UserInterface/Base/Setting.js:
* UserInterface/Protocol/LoggingProtocolTracer.js:
(WI.LoggingProtocolTracer.prototype._processEntry):
(WI.LoggingProtocolTracer):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createDebugSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (249013 => 249014)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-22 16:26:04 UTC (rev 249013)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-22 16:42:57 UTC (rev 249014)
@@ -1,3 +1,17 @@
+2019-08-22 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Provide an engineering option to log protocol traffic as text
+ https://bugs.webkit.org/show_bug.cgi?id=200969
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Protocol/LoggingProtocolTracer.js:
+ (WI.LoggingProtocolTracer.prototype._processEntry):
+ (WI.LoggingProtocolTracer):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createDebugSettingsView):
+
2019-08-21 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: RTL: DOM outline in Elements tab should be LTR
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (249013 => 249014)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-08-22 16:26:04 UTC (rev 249013)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-08-22 16:42:57 UTC (rev 249014)
@@ -189,6 +189,7 @@
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
// Protocol
+ protocolLogAsText: new WI.Setting("protocol-log-as-text", false),
protocolAutoLogMessages: new WI.Setting("protocol-auto-log-messages", false),
protocolAutoLogTimeStats: new WI.Setting("protocol-auto-log-time-stats", false),
protocolFilterMultiplexingBackendMessages: new WI.Setting("protocol-filter-multiplexing-backend-messages", true),
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js (249013 => 249014)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2019-08-22 16:26:04 UTC (rev 249013)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2019-08-22 16:42:57 UTC (rev 249014)
@@ -121,7 +121,7 @@
return;
let prefix = `${entry.type} (${targetId})`;
- if (!window.InspectorTest && InspectorFrontendHost.isBeingInspected()) {
+ if (!window.InspectorTest && InspectorFrontendHost.isBeingInspected() && !WI.settings.protocolLogAsText.value) {
if (entry.type === "request" || entry.type === "exception")
console.trace(prefix, entry.message);
else
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (249013 => 249014)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-08-22 16:26:04 UTC (rev 249013)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-08-22 16:42:57 UTC (rev 249014)
@@ -413,6 +413,7 @@
});
protocolMessagesGroup.addSetting(WI.settings.protocolAutoLogTimeStats, WI.unlocalizedString("Time Stats"));
+ protocolMessagesGroup.addSetting(WI.settings.protocolLogAsText, WI.unlocalizedString("Log as Text"));
this._debugSettingsView.addSeparator();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
