Title: [249081] trunk/Source/WebCore
- Revision
- 249081
- Author
- za...@apple.com
- Date
- 2019-08-24 06:16:41 -0700 (Sat, 24 Aug 2019)
Log Message
[LFC] Remove redundant Layout::Box::ElementType::TableRowGroup
https://bugs.webkit.org/show_bug.cgi?id=201112
<rdar://problem/54663833>
Reviewed by Antti Koivisto.
Use Layout::Box::ElementType::TableBodyGroup instead.
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isPaddingApplicable const):
* layout/layouttree/LayoutBox.h:
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249080 => 249081)
--- trunk/Source/WebCore/ChangeLog 2019-08-24 03:31:55 UTC (rev 249080)
+++ trunk/Source/WebCore/ChangeLog 2019-08-24 13:16:41 UTC (rev 249081)
@@ -1,3 +1,19 @@
+2019-08-24 Zalan Bujtas <za...@apple.com>
+
+ [LFC] Remove redundant Layout::Box::ElementType::TableRowGroup
+ https://bugs.webkit.org/show_bug.cgi?id=201112
+ <rdar://problem/54663833>
+
+ Reviewed by Antti Koivisto.
+
+ Use Layout::Box::ElementType::TableBodyGroup instead.
+
+ * layout/layouttree/LayoutBox.cpp:
+ (WebCore::Layout::Box::isPaddingApplicable const):
+ * layout/layouttree/LayoutBox.h:
+ * layout/layouttree/LayoutTreeBuilder.cpp:
+ (WebCore::Layout::TreeBuilder::createLayoutBox):
+
2019-08-23 Simon Fraser <simon.fra...@apple.com>
RenderLayerModelObject should not call private RenderLayer functions
Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp (249080 => 249081)
--- trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2019-08-24 03:31:55 UTC (rev 249080)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2019-08-24 13:16:41 UTC (rev 249081)
@@ -366,8 +366,8 @@
return false;
auto elementType = m_elementAttributes.value().elementType;
- return elementType != ElementType::TableRowGroup
- && elementType != ElementType::TableHeaderGroup
+ return elementType != ElementType::TableHeaderGroup
+ && elementType != ElementType::TableBodyGroup
&& elementType != ElementType::TableFooterGroup
&& elementType != ElementType::TableRow
&& elementType != ElementType::TableColumnGroup
Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.h (249080 => 249081)
--- trunk/Source/WebCore/layout/layouttree/LayoutBox.h 2019-08-24 03:31:55 UTC (rev 249080)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.h 2019-08-24 13:16:41 UTC (rev 249081)
@@ -50,7 +50,6 @@
TableColumn,
TableRow,
TableColumnGroup,
- TableRowGroup,
TableHeaderGroup,
TableBodyGroup,
TableFooterGroup,
Modified: trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp (249080 => 249081)
--- trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-08-24 03:31:55 UTC (rev 249080)
+++ trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-08-24 13:16:41 UTC (rev 249081)
@@ -106,8 +106,6 @@
return Box::ElementAttributes { Box::ElementType::TableRow };
if (element->hasTagName(HTMLNames::colgroupTag))
return Box::ElementAttributes { Box::ElementType::TableColumnGroup };
- if (element->hasTagName(HTMLNames::tbodyTag))
- return Box::ElementAttributes { Box::ElementType::TableRowGroup };
if (element->hasTagName(HTMLNames::theadTag))
return Box::ElementAttributes { Box::ElementType::TableHeaderGroup };
if (element->hasTagName(HTMLNames::tbodyTag))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
