Title: [249355] trunk/Tools
Revision
249355
Author
aakash_j...@apple.com
Date
2019-08-30 19:01:10 -0700 (Fri, 30 Aug 2019)

Log Message

[ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
https://bugs.webkit.org/show_bug.cgi?id=201350

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(RunWebKit1Tests.start): Set build property to use dump-render-tree.
(RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (249354 => 249355)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-31 00:45:17 UTC (rev 249354)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-31 02:01:10 UTC (rev 249355)
@@ -904,6 +904,9 @@
         appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
         additionalArguments = self.getProperty('additionalArguments')
 
+        if self.getProperty('use-dump-render-tree', False):
+            self.setCommand(self.command + ['--dump-render-tree'])
+
         self.setCommand(self.command + ['--results-directory', self.resultDirectory])
         self.setCommand(self.command + ['--debug-rwt-logging'])
 
@@ -1159,8 +1162,7 @@
 
 class RunWebKit1Tests(RunWebKitTests):
     def start(self):
-        self.setCommand(self.command + ['--dump-render-tree'])
-
+        self.setProperty('use-dump-render-tree', True)
         return RunWebKitTests.start(self)
 
 

Modified: trunk/Tools/ChangeLog (249354 => 249355)


--- trunk/Tools/ChangeLog	2019-08-31 00:45:17 UTC (rev 249354)
+++ trunk/Tools/ChangeLog	2019-08-31 02:01:10 UTC (rev 249355)
@@ -1,3 +1,14 @@
+2019-08-30  Aakash Jain  <aakash_j...@apple.com>
+
+        [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
+        https://bugs.webkit.org/show_bug.cgi?id=201350
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunWebKit1Tests.start): Set build property to use dump-render-tree.
+        (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
+
 2019-08-30  Jonathan Bedard  <jbed...@apple.com>
 
         results.webkit.org: Add endpoints to upload and download archives
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to