Modified: trunk/LayoutTests/ChangeLog (249736 => 249737)
--- trunk/LayoutTests/ChangeLog 2019-09-10 22:07:08 UTC (rev 249736)
+++ trunk/LayoutTests/ChangeLog 2019-09-10 22:28:32 UTC (rev 249737)
@@ -1,3 +1,16 @@
+2019-09-10 Jiewen Tan <jiewen_...@apple.com>
+
+ REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=201620
+ <rdar://problem/51524958>
+
+ Reviewed by Alex Christensen.
+
+ * http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
+ Remove the timeout value given those tests should never time out.
+ * platform/mac-wk2/TestExpectations:
+ Change the test expectation to Pass.
+
2019-09-10 Said Abou-Hallawa <sabouhall...@apple.com>
REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html (249736 => 249737)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html 2019-09-10 22:07:08 UTC (rev 249736)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-u2f.https.html 2019-09-10 22:28:32 UTC (rev 249737)
@@ -18,7 +18,6 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
- timeout: 100
}
};
@@ -43,7 +42,6 @@
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
excludeCredentials: [{ type: "public-key", id: Base64URL.parse(testCredentialIdBase64) }],
- timeout: 100
}
};
@@ -68,7 +66,6 @@
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
excludeCredentials: [{ type: "public-key", id: Base64URL.parse(testCredentialIdBase64) }, { type: "public-key", id: Base64URL.parse(testCredentialIdBase64) }], // The content doesn't matter.
- timeout: 100
}
};
@@ -92,7 +89,6 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
- timeout: 500
}
};
@@ -117,7 +113,6 @@
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
attestation: "none",
- timeout: 100
}
};
@@ -142,7 +137,6 @@
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
attestation: "indirect",
- timeout: 100
}
};
@@ -167,7 +161,6 @@
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
attestation: "direct",
- timeout: 100
}
};
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (249736 => 249737)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-09-10 22:07:08 UTC (rev 249736)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-09-10 22:28:32 UTC (rev 249737)
@@ -965,9 +965,6 @@
webkit.org/b/195635 scrollingcoordinator/mac/multiple-fixed.html [ Pass Timeout ]
-# <rdar://problem/51524958> REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing
-[ Catalina+ ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html [ Failure ]
-
webkit.org/b/199651 [ Mojave Debug ] webgpu/whlsl/builtin-vectors-2.html [ Slow ]
webkit.org/b/199089 [ Mojave+ Debug ] plugins/window-open.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (249736 => 249737)
--- trunk/Source/WebCore/ChangeLog 2019-09-10 22:07:08 UTC (rev 249736)
+++ trunk/Source/WebCore/ChangeLog 2019-09-10 22:28:32 UTC (rev 249737)
@@ -1,3 +1,17 @@
+2019-09-10 Jiewen Tan <jiewen_...@apple.com>
+
+ REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=201620
+ <rdar://problem/51524958>
+
+ Reviewed by Alex Christensen.
+
+ Covered by existing tests.
+
+ * Modules/webauthn/fido/U2fResponseConverter.cpp:
+ (fido::WebCore::createAttestedCredentialDataFromU2fRegisterResponse):
+ Change the way how the aaguid is initialized to see if that fixes the issue.
+
2019-09-10 Chris Dumez <cdu...@apple.com>
Add missing origin check for Service-Worker-Allowed header
Modified: trunk/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp (249736 => 249737)
--- trunk/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp 2019-09-10 22:07:08 UTC (rev 249736)
+++ trunk/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp 2019-09-10 22:28:32 UTC (rev 249737)
@@ -98,7 +98,9 @@
if (credentialId.isEmpty())
return { };
- return buildAttestedCredentialData(Vector<uint8_t>(aaguidLength, 0), credentialId, publicKey);
+ Vector<uint8_t> aaguid(aaguidLength);
+ memset(aaguid.data(), 0, aaguidLength);
+ return buildAttestedCredentialData(aaguid, credentialId, publicKey);
}
static size_t parseX509Length(const Vector<uint8_t>& u2fData, size_t offset)
