Title: [249750] trunk/Source/WebKitLegacy
Revision
249750
Author
hironori.fu...@sony.com
Date
2019-09-10 18:57:06 -0700 (Tue, 10 Sep 2019)

Log Message

Unreviewed, rolling out r239097.

This is not a right fix. DumpRenderTree, MiniBrowser and
TestWebKitAPI are still reporting the same warning.

Reverted changeset:

"[Win][WebKitLegacy][Clang] WebKit.h warning:
'IWebEditingDelegate2::shouldInsertNode' hides overloaded
virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=192581
https://trac.webkit.org/changeset/239097

Modified Paths

Diff

Modified: trunk/Source/WebKitLegacy/ChangeLog (249749 => 249750)


--- trunk/Source/WebKitLegacy/ChangeLog	2019-09-11 01:12:37 UTC (rev 249749)
+++ trunk/Source/WebKitLegacy/ChangeLog	2019-09-11 01:57:06 UTC (rev 249750)
@@ -1,3 +1,18 @@
+2019-09-10  Fujii Hironori  <hironori.fu...@sony.com>
+
+        Unreviewed, rolling out r239097.
+
+        This is not a right fix. DumpRenderTree, MiniBrowser and
+        TestWebKitAPI are still reporting the same warning.
+
+        Reverted changeset:
+
+        "[Win][WebKitLegacy][Clang] WebKit.h warning:
+        'IWebEditingDelegate2::shouldInsertNode' hides overloaded
+        virtual function [-Woverloaded-virtual]"
+        https://bugs.webkit.org/show_bug.cgi?id=192581
+        https://trac.webkit.org/changeset/239097
+
 2019-09-03  Chris Dumez  <cdu...@apple.com>
 
         FrameLoader::FrameProgressTracker::progressCompleted() does not need a pageID

Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (249749 => 249750)


--- trunk/Source/WebKitLegacy/PlatformWin.cmake	2019-09-11 01:12:37 UTC (rev 249749)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake	2019-09-11 01:57:06 UTC (rev 249750)
@@ -267,10 +267,6 @@
     endif ()
 endif ()
 
-if (COMPILER_IS_GCC_OR_CLANG)
-    WEBKIT_ADD_TARGET_CXX_FLAGS(WebKitLegacy -Wno-overloaded-virtual)
-endif ()
-
 list(APPEND WebKitLegacy_SOURCES ${WebKitLegacy_INCLUDES} ${WebKitLegacy_SOURCES_Classes} ${WebKitLegacy_SOURCES_WebCoreSupport})
 
 source_group(Includes FILES ${WebKitLegacy_INCLUDES})
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to