Title: [103040] trunk/Tools
- Revision
- 103040
- Author
- ph...@webkit.org
- Date
- 2011-12-16 00:28:21 -0800 (Fri, 16 Dec 2011)
Log Message
[GTK] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=72254
Initial patch by van...@gmail.com.
Reviewed by Martin Robinson.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Pass additional
CXXFLAGS to autogen in an attempt to harmonize floating point
values between 32-bit and 64-bit architectures.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (103039 => 103040)
--- trunk/Tools/ChangeLog 2011-12-16 08:27:17 UTC (rev 103039)
+++ trunk/Tools/ChangeLog 2011-12-16 08:28:21 UTC (rev 103040)
@@ -1,3 +1,16 @@
+2011-12-15 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] Rounding errors on 32-bit machines causes tests to fail
+ https://bugs.webkit.org/show_bug.cgi?id=72254
+
+ Initial patch by van...@gmail.com.
+ Reviewed by Martin Robinson.
+
+ * Scripts/webkitdirs.pm:
+ (runAutogenForAutotoolsProjectIfNecessary): Pass additional
+ CXXFLAGS to autogen in an attempt to harmonize floating point
+ values between 32-bit and 64-bit architectures.
+
2011-12-16 Martin Robinson <mrobin...@igalia.com>
[GTK] Make distcheck fails during the install
Modified: trunk/Tools/Scripts/webkitdirs.pm (103039 => 103040)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 08:27:17 UTC (rev 103039)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-12-16 08:28:21 UTC (rev 103040)
@@ -1621,6 +1621,14 @@
# Long argument lists cause bizarre slowdowns in libtool.
my $relSourceDir = File::Spec->abs2rel($sourceDir) || ".";
+ # Compiler options to keep floating point values consistent
+ # between 32-bit and 64-bit architectures. The options are also
+ # used on Chromium build.
+ determineArchitecture();
+ if ($architecture ne "x86_64") {
+ $ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse";
+ }
+
# Prefix the command with jhbuild run.
unshift(@buildArgs, "$relSourceDir/autogen.sh");
unshift(@buildArgs, "$sourceDir/Tools/gtk/run-with-jhbuild");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
