Title: [250130] trunk/Source/WebKit
- Revision
- 250130
- Author
- cdu...@apple.com
- Date
- 2019-09-20 08:23:50 -0700 (Fri, 20 Sep 2019)
Log Message
Regression(r248832): Unable to quicklook HTML files in Mail
https://bugs.webkit.org/show_bug.cgi?id=202012
<rdar://problem/55285295>
Reviewed by Per Arne Vollan.
Follow-up to fix bug in r250110. Now that loadFile() calls
maybeInitializeSandboxExtensionHandle(), it no longer needs to
call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle()
already take care of it.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (250129 => 250130)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 15:07:19 UTC (rev 250129)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 15:23:50 UTC (rev 250130)
@@ -1,3 +1,19 @@
+2019-09-20 Chris Dumez <cdu...@apple.com>
+
+ Regression(r248832): Unable to quicklook HTML files in Mail
+ https://bugs.webkit.org/show_bug.cgi?id=202012
+ <rdar://problem/55285295>
+
+ Reviewed by Per Arne Vollan.
+
+ Follow-up to fix bug in r250110. Now that loadFile() calls
+ maybeInitializeSandboxExtensionHandle(), it no longer needs to
+ call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle()
+ already take care of it.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::loadFile):
+
2019-09-20 Joonghun Park <pjh0...@gmail.com>
Unreviewed. Remove duplicated HashMap iteration since r248734.
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (250129 => 250130)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:07:19 UTC (rev 250129)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-09-20 15:23:50 UTC (rev 250130)
@@ -1236,7 +1236,6 @@
maybeInitializeSandboxExtensionHandle(m_process, fileURL, resourceDirectoryURL, loadParameters.sandboxExtensionHandle);
addPlatformLoadParameters(loadParameters);
- m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);
#if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID)
if (m_process->isLaunching())
m_process->send(Messages::WebPage::LoadRequestWaitingForPID(loadParameters, resourceDirectoryURL, m_identifier), m_webPageID);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
