Title: [250138] trunk
- Revision
- 250138
- Author
- krol...@apple.com
- Date
- 2019-09-20 12:31:24 -0700 (Fri, 20 Sep 2019)
Log Message
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=201973
<rdar://problem/55506966>
Reviewed by Alex Christensen.
Remove some support for iOS versions less than 13.0.
Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Chris Dumez was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.
Source/WebKit:
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::resume):
Source/WTF:
* wtf/FeatureDefines.h:
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (250137 => 250138)
--- trunk/Source/WTF/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Source/WTF/ChangeLog 2019-09-20 19:31:24 UTC (rev 250138)
@@ -1,3 +1,27 @@
+2019-09-20 Keith Rollin <krol...@apple.com>
+
+ Remove some support for < iOS 13
+ https://bugs.webkit.org/show_bug.cgi?id=201973
+ <rdar://problem/55506966>
+
+ Reviewed by Alex Christensen.
+
+ Remove some support for iOS versions less than 13.0.
+
+ Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
+ and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
+ values >= 130000. This means that expressions like
+ "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
+ "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
+
+ This removal is part of a series of patches effecting the removal of
+ dead code for old versions of iOS. This particular pass involves
+ changes in which Chris Dumez was involved. These changes are isolated
+ from other similar changes in order to facilitate the reviewing
+ process.
+
+ * wtf/FeatureDefines.h:
+
2019-09-20 Paulo Matos <pma...@igalia.com>
Implement memory monitoring functions for Linux OS
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (250137 => 250138)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2019-09-20 19:31:24 UTC (rev 250138)
@@ -186,16 +186,12 @@
#endif
#if !defined(HAVE_VISIBILITY_PROPAGATION_VIEW)
-#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000
#define HAVE_VISIBILITY_PROPAGATION_VIEW 1
#endif
-#endif
#if !defined(HAVE_UISCENE)
-#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || PLATFORM(APPLETV) || PLATFORM(WATCHOS)
#define HAVE_UISCENE 1
#endif
-#endif
#if !defined(HAVE_AVSTREAMSESSION)
#define HAVE_AVSTREAMSESSION 0
Modified: trunk/Source/WebKit/ChangeLog (250137 => 250138)
--- trunk/Source/WebKit/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Source/WebKit/ChangeLog 2019-09-20 19:31:24 UTC (rev 250138)
@@ -1,3 +1,28 @@
+2019-09-20 Keith Rollin <krol...@apple.com>
+
+ Remove some support for < iOS 13
+ https://bugs.webkit.org/show_bug.cgi?id=201973
+ <rdar://problem/55506966>
+
+ Reviewed by Alex Christensen.
+
+ Remove some support for iOS versions less than 13.0.
+
+ Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
+ and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
+ values >= 130000. This means that expressions like
+ "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
+ "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
+
+ This removal is part of a series of patches effecting the removal of
+ dead code for old versions of iOS. This particular pass involves
+ changes in which Chris Dumez was involved. These changes are isolated
+ from other similar changes in order to facilitate the reviewing
+ process.
+
+ * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
+ (WebKit::Download::resume):
+
2019-09-20 Chris Dumez <cdu...@apple.com>
Unreviewed, fix confusing release logging under WebPageProxy::loadRequestWithNavigationShared().
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm (250137 => 250138)
--- trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm 2019-09-20 19:31:24 UTC (rev 250138)
@@ -48,8 +48,8 @@
auto& cocoaSession = static_cast<NetworkSessionCocoa&>(*networkSession);
auto nsData = adoptNS([[NSData alloc] initWithBytes:resumeData.data() length:resumeData.size()]);
- // FIXME: This is a temporary workaround for <rdar://problem/34745171>.
-#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)
+ // FIXME: This is a temporary workaround for <rdar://problem/34745171>. Fixed in iOS 13 and macOS 10.15, but we still need to support macOS 10.14 for now.
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
static NSSet<Class> *plistClasses = nil;
static dispatch_once_t onceToken;
Modified: trunk/Tools/ChangeLog (250137 => 250138)
--- trunk/Tools/ChangeLog 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Tools/ChangeLog 2019-09-20 19:31:24 UTC (rev 250138)
@@ -1,3 +1,27 @@
+2019-09-20 Keith Rollin <krol...@apple.com>
+
+ Remove some support for < iOS 13
+ https://bugs.webkit.org/show_bug.cgi?id=201973
+ <rdar://problem/55506966>
+
+ Reviewed by Alex Christensen.
+
+ Remove some support for iOS versions less than 13.0.
+
+ Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
+ and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
+ values >= 130000. This means that expressions like
+ "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
+ "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
+
+ This removal is part of a series of patches effecting the removal of
+ dead code for old versions of iOS. This particular pass involves
+ changes in which Chris Dumez was involved. These changes are isolated
+ from other similar changes in order to facilitate the reviewing
+ process.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2019-09-19 Brent Fulgham <bfulg...@apple.com>
[FTW] Enable WebKitTestRunner build
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (250137 => 250138)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-09-20 18:42:48 UTC (rev 250137)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-09-20 19:31:24 UTC (rev 250138)
@@ -69,7 +69,7 @@
static int numberOfDecidePolicyCalls;
static bool didRepondToPolicyDecisionCall;
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+#if PLATFORM(IOS_FAMILY)
static bool requestedQuickLookPassword;
static bool didStartQuickLookLoad;
static bool didFinishQuickLookLoad;
@@ -179,7 +179,7 @@
didPerformClientRedirect = true;
}
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+#if PLATFORM(IOS_FAMILY)
- (void)_webViewDidRequestPasswordForQuickLookDocument:(WKWebView *)webView
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
