Title: [103109] trunk
Revision
103109
Author
aba...@webkit.org
Date
2011-12-16 14:29:02 -0800 (Fri, 16 Dec 2011)

Log Message

<!doctype html><div><body><frameset> doesn't parse correctly
https://bugs.webkit.org/show_bug.cgi?id=74745

Reviewed by Eric Seidel.

Source/WebCore: 

We were missing one place the spec tells us to set this bool.

Tests: html5lib/runner.html

* html/parser/HTMLTreeBuilder.cpp:

LayoutTests: 

Show test progression.

* html5lib/runner-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (103108 => 103109)


--- trunk/LayoutTests/ChangeLog	2011-12-16 22:28:38 UTC (rev 103108)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 22:29:02 UTC (rev 103109)
@@ -1,3 +1,14 @@
+2011-12-16  Adam Barth  <aba...@webkit.org>
+
+        <!doctype html><div><body><frameset> doesn't parse correctly
+        https://bugs.webkit.org/show_bug.cgi?id=74745
+
+        Reviewed by Eric Seidel.
+
+        Show test progression.
+
+        * html5lib/runner-expected.txt:
+
 2011-12-16  Tony Chang  <t...@chromium.org>
 
         Unreviewed, updating chromium expectations.

Modified: trunk/LayoutTests/html5lib/runner-expected.txt (103108 => 103109)


--- trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 22:28:38 UTC (rev 103108)
+++ trunk/LayoutTests/html5lib/runner-expected.txt	2011-12-16 22:29:02 UTC (rev 103109)
@@ -156,22 +156,8 @@
 
 resources/tests18.dat: PASS
 
-resources/tests19.dat:
-81
+resources/tests19.dat: PASS
 
-Test 81 of 104 in resources/tests19.dat failed. Input:
-<!doctype html><div><body><frameset>
-Got:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <frameset>
-Expected:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <body>
-|     <div>
 resources/tests20.dat:
 31
 

Modified: trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt (103108 => 103109)


--- trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 22:28:38 UTC (rev 103108)
+++ trunk/LayoutTests/platform/chromium/html5lib/runner-expected.txt	2011-12-16 22:29:02 UTC (rev 103109)
@@ -126,28 +126,8 @@
 
 resources/tests2.dat: PASS
 
-resources/tests3.dat:
-12
+resources/tests3.dat: PASS
 
-Test 12 of 24 in resources/tests3.dat failed. Input:
-<!DOCTYPE html><pre>&#x0a;&#x0a;A</pre>
-Got:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <body>
-|     <pre>
-|       "
-
-A"
-Expected:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <body>
-|     <pre>
-|       "
-A"
 resources/tests4.dat: PASS
 
 resources/tests5.dat: PASS
@@ -176,22 +156,8 @@
 
 resources/tests18.dat: PASS
 
-resources/tests19.dat:
-81
+resources/tests19.dat: PASS
 
-Test 81 of 104 in resources/tests19.dat failed. Input:
-<!doctype html><div><body><frameset>
-Got:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <frameset>
-Expected:
-| <!DOCTYPE html>
-| <html>
-|   <head>
-|   <body>
-|     <div>
 resources/tests20.dat:
 31
 

Modified: trunk/Source/WebCore/ChangeLog (103108 => 103109)


--- trunk/Source/WebCore/ChangeLog	2011-12-16 22:28:38 UTC (rev 103108)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 22:29:02 UTC (rev 103109)
@@ -1,3 +1,16 @@
+2011-12-16  Adam Barth  <aba...@webkit.org>
+
+        <!doctype html><div><body><frameset> doesn't parse correctly
+        https://bugs.webkit.org/show_bug.cgi?id=74745
+
+        Reviewed by Eric Seidel.
+
+        We were missing one place the spec tells us to set this bool.
+
+        Tests: html5lib/runner.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+
 2011-12-16  Jarred Nicholls  <jar...@sencha.com>
 
         Support HTML documents in XHR.responseXML

Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (103108 => 103109)


--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2011-12-16 22:28:38 UTC (rev 103108)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2011-12-16 22:29:02 UTC (rev 103109)
@@ -765,6 +765,7 @@
             ASSERT(isParsingFragment());
             return;
         }
+        m_framesetOk = false;
         m_tree.insertHTMLBodyStartTagInBody(token);
         return;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to