[webkit-changes] [250847] trunk/Tools

Tue, 08 Oct 2019 12:00:57 -0700

Title: [250847] trunk/Tools
Revision
250847
Author
aakash_j...@apple.com
Date
2019-10-08 11:59:37 -0700 (Tue, 08 Oct 2019)

Log Message

[ews-build] Do not print worker environment variables in each build step [part 3]
https://bugs.webkit.org/show_bug.cgi?id=202698

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(RunJavaScriptCoreTests.__init__): Disabled logging of environment variables.
(ExtractTestResults.__init__): Ditto.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (250846 => 250847)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-10-08 18:58:52 UTC (rev 250846)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-10-08 18:59:37 UTC (rev 250847)
@@ -844,6 +844,9 @@
     logfiles = {'json': jsonFileName}
     command = ['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(jsonFileName), WithProperties('--%(configuration)s')]
 
+    def __init__(self, **kwargs):
+        shell.Test.__init__(self, logEnviron=False, **kwargs)
+
     def start(self):
         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
         return shell.Test.start(self)
@@ -1508,7 +1511,7 @@
         self.resultDirectory = Interpolate('public_html/results/%(prop:buildername)s/r%(prop:patch_id)s-%(prop:buildnumber)s{}'.format(identifier))
         self.command = ['unzip', self.zipFile, '-d', self.resultDirectory]
 
-        super(ExtractTestResults, self).__init__(self.command)
+        master.MasterShellCommand.__init__(self, command=self.command, logEnviron=False)
 
     def resultDirectoryURL(self):
         return self.resultDirectory.replace('public_html/', '/') + '/'

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (250846 => 250847)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2019-10-08 18:58:52 UTC (rev 250846)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2019-10-08 18:59:37 UTC (rev 250847)
@@ -966,6 +966,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
                         )
@@ -980,6 +981,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},
                         )
@@ -1005,6 +1007,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
                         )
@@ -1019,6 +1022,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},
                         )
@@ -1044,6 +1048,7 @@
         self.setProperty('configuration', 'release')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
                         logfiles={'json': self.jsonFileName},
                         )
@@ -1058,6 +1063,7 @@
         self.setProperty('configuration', 'debug')
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        logEnviron=False,
                         command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
                         logfiles={'json': self.jsonFileName},
                         )

Modified: trunk/Tools/ChangeLog (250846 => 250847)


--- trunk/Tools/ChangeLog	2019-10-08 18:58:52 UTC (rev 250846)
+++ trunk/Tools/ChangeLog	2019-10-08 18:59:37 UTC (rev 250847)
@@ -1,3 +1,15 @@
+2019-10-08  Aakash Jain  <aakash_j...@apple.com>
+
+        [ews-build] Do not print worker environment variables in each build step [part 3]
+        https://bugs.webkit.org/show_bug.cgi?id=202698
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunJavaScriptCoreTests.__init__): Disabled logging of environment variables.
+        (ExtractTestResults.__init__): Ditto.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2019-10-08  Matt Lewis  <jlew...@apple.com>
 
         Fixing the triggerable templates in the config for catalina.

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to