Title: [250980] trunk/Source/WebCore
- Revision
- 250980
- Author
- [email protected]
- Date
- 2019-10-10 11:42:17 -0700 (Thu, 10 Oct 2019)
Log Message
MockRealtimeVideoSource::setFrameRateWithPreset should not use preset after moving it
https://bugs.webkit.org/show_bug.cgi?id=202800
Reviewed by Alexey Proskuryakov.
This does not affect behavior right now since clients typically get the intrinsic size through media samples.
But this could create some inconsistencies.
* platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250979 => 250980)
--- trunk/Source/WebCore/ChangeLog 2019-10-10 18:35:39 UTC (rev 250979)
+++ trunk/Source/WebCore/ChangeLog 2019-10-10 18:42:17 UTC (rev 250980)
@@ -1,3 +1,16 @@
+2019-10-10 youenn fablet <[email protected]>
+
+ MockRealtimeVideoSource::setFrameRateWithPreset should not use preset after moving it
+ https://bugs.webkit.org/show_bug.cgi?id=202800
+
+ Reviewed by Alexey Proskuryakov.
+
+ This does not affect behavior right now since clients typically get the intrinsic size through media samples.
+ But this could create some inconsistencies.
+
+ * platform/mock/MockRealtimeVideoSource.cpp:
+ (WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):
+
2019-10-10 Devin Rousso <[email protected]>
Web Inspector: Timelines: don't call willDispatchEvent/didDispatchEvent unless there is a listener for the event
Modified: trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp (250979 => 250980)
--- trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp 2019-10-10 18:35:39 UTC (rev 250979)
+++ trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp 2019-10-10 18:42:17 UTC (rev 250980)
@@ -189,8 +189,8 @@
void MockRealtimeVideoSource::setFrameRateWithPreset(double, RefPtr<VideoPreset> preset)
{
m_preset = WTFMove(preset);
- if (preset)
- setIntrinsicSize(preset->size);
+ if (m_preset)
+ setIntrinsicSize(m_preset->size);
}
IntSize MockRealtimeVideoSource::captureSize() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
