Title: [251908] trunk/Source/WebCore
- Revision
- 251908
- Author
- hironori.fu...@sony.com
- Date
- 2019-10-31 21:41:37 -0700 (Thu, 31 Oct 2019)
Log Message
[WinCairo][Clang] Unreviewed build fix
https://bugs.webkit.org/show_bug.cgi?id=203663
ServiceWorkerThreadProxy::notifyNetworkStateChange was not
exported from WebKit.dll even though it's marked with
WEBCORE_TESTSUPPORT_EXPORT because any symbols in the object file of
ServiceWorkerThreadProxy.cpp is not referred by WebKit.dll.
> WebCoreTestSupport.lib(ServiceWorkerInternals.cpp.obj) : error LNK2019: unresolved external symbol
> "__declspec(dllimport) public: void __cdecl WebCore::ServiceWorkerThreadProxy::notifyNetworkStateChange(bool)"
> (__imp_?notifyNetworkStateChange@ServiceWorkerThreadProxy@WebCore@@QEAAX_N@Z) referenced in function
> "public: <auto> __cdecl `public: void __cdecl WebCore::ServiceWorkerInternals::setOnline(bool)'::`1'::<lambda_0>::operator()(void)const "
> (??R<lambda_0>@?0??setOnline@ServiceWorkerInternals@WebCore@@QEAAX_N@Z@QEBA?A?<auto>@@XZ)
Uninline ServiceWorkerThreadProxy::identifier temporarily.
I will revert this change after fixing this issue properly in Bug 203663.
No behavioral changes.
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::identifier const):
* workers/service/context/ServiceWorkerThreadProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (251907 => 251908)
--- trunk/Source/WebCore/ChangeLog 2019-11-01 04:07:37 UTC (rev 251907)
+++ trunk/Source/WebCore/ChangeLog 2019-11-01 04:41:37 UTC (rev 251908)
@@ -1,3 +1,28 @@
+2019-10-31 Fujii Hironori <hironori.fu...@sony.com>
+
+ [WinCairo][Clang] Unreviewed build fix
+ https://bugs.webkit.org/show_bug.cgi?id=203663
+
+ ServiceWorkerThreadProxy::notifyNetworkStateChange was not
+ exported from WebKit.dll even though it's marked with
+ WEBCORE_TESTSUPPORT_EXPORT because any symbols in the object file of
+ ServiceWorkerThreadProxy.cpp is not referred by WebKit.dll.
+
+ > WebCoreTestSupport.lib(ServiceWorkerInternals.cpp.obj) : error LNK2019: unresolved external symbol
+ > "__declspec(dllimport) public: void __cdecl WebCore::ServiceWorkerThreadProxy::notifyNetworkStateChange(bool)"
+ > (__imp_?notifyNetworkStateChange@ServiceWorkerThreadProxy@WebCore@@QEAAX_N@Z) referenced in function
+ > "public: <auto> __cdecl `public: void __cdecl WebCore::ServiceWorkerInternals::setOnline(bool)'::`1'::<lambda_0>::operator()(void)const "
+ > (??R<lambda_0>@?0??setOnline@ServiceWorkerInternals@WebCore@@QEAAX_N@Z@QEBA?A?<auto>@@XZ)
+
+ Uninline ServiceWorkerThreadProxy::identifier temporarily.
+ I will revert this change after fixing this issue properly in Bug 203663.
+
+ No behavioral changes.
+
+ * workers/service/context/ServiceWorkerThreadProxy.cpp:
+ (WebCore::ServiceWorkerThreadProxy::identifier const):
+ * workers/service/context/ServiceWorkerThreadProxy.h:
+
2019-10-31 Brent Fulgham <bfulg...@apple.com>
[FTW] Adopt DirectWrite in place of Uniscribe
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (251907 => 251908)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2019-11-01 04:07:37 UTC (rev 251907)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp 2019-11-01 04:41:37 UTC (rev 251908)
@@ -123,6 +123,11 @@
allServiceWorkerThreadProxies().remove(this);
}
+ServiceWorkerIdentifier ServiceWorkerThreadProxy::identifier() const
+{
+ return m_serviceWorkerThread->identifier();
+}
+
bool ServiceWorkerThreadProxy::postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task&& task, const String& mode)
{
if (m_isTerminatingOrTerminated)
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h (251907 => 251908)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h 2019-11-01 04:07:37 UTC (rev 251907)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h 2019-11-01 04:41:37 UTC (rev 251908)
@@ -57,7 +57,7 @@
}
WEBCORE_EXPORT ~ServiceWorkerThreadProxy();
- ServiceWorkerIdentifier identifier() const { return m_serviceWorkerThread->identifier(); }
+ ServiceWorkerIdentifier identifier() const;
ServiceWorkerThread& thread() { return m_serviceWorkerThread.get(); }
ServiceWorkerInspectorProxy& inspectorProxy() { return m_inspectorProxy; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
