Diff
Modified: trunk/Source/WebKit/ChangeLog (252654 => 252655)
--- trunk/Source/WebKit/ChangeLog 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/ChangeLog 2019-11-20 00:32:19 UTC (rev 252655)
@@ -1,3 +1,61 @@
+2019-11-19 Chris Dumez <[email protected]>
+
+ Protect MessageReceivers when possible while they are processing incoming IPC messages
+ https://bugs.webkit.org/show_bug.cgi?id=204377
+
+ Reviewed by Brady Eidson.
+
+ Protect MessageReceiver while they are processing incoming IPC messages for
+ extra safety. It is a common mistake to call client delegates as a result of an IPC, and
+ failing to protect |this| while doing so. Client code can destroy |this| and we end up
+ crashing.
+
+ For MessageReceivers that are not RefCounted, they can use the "NotRefCounted" attribute
+ in their messages.in file to opt out.
+
+ * NetworkProcess/Cookies/WebCookieManager.messages.in:
+ * NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in:
+ * NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
+ * NetworkProcess/NetworkContentRuleListManager.messages.in:
+ * NetworkProcess/NetworkSocketChannel.messages.in:
+ * NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
+ * NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
+ * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
+ * NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
+ * NetworkProcess/webrtc/NetworkRTCMonitor.messages.in:
+ * NetworkProcess/webrtc/NetworkRTCSocket.messages.in:
+ * PluginProcess/PluginControllerProxy.messages.in:
+ * PluginProcess/PluginProcess.messages.in:
+ * Scripts/webkit/messages.py:
+ * Shared/API/Cocoa/RemoteObjectRegistry.messages.in:
+ * Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
+ * Shared/Authentication/AuthenticationManager.messages.in:
+ * Shared/AuxiliaryProcess.messages.in:
+ * Shared/Plugins/NPObjectMessageReceiver.messages.in:
+ * UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
+ * UIProcess/DrawingAreaProxy.messages.in:
+ * UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in:
+ * UIProcess/Network/NetworkProcessProxy.messages.in:
+ * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:
+ * UIProcess/ViewGestureController.messages.in:
+ * UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
+ * UIProcess/WebFullScreenManagerProxy.messages.in:
+ * UIProcess/WebPasteboardProxy.messages.in:
+ * UIProcess/ios/SmartMagnificationController.messages.in:
+ * WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
+ * WebProcess/Automation/WebAutomationSessionProxy.messages.in:
+ * WebProcess/Geolocation/WebGeolocationManager.messages.in:
+ * WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
+ * WebProcess/Network/webrtc/WebRTCMonitor.messages.in:
+ * WebProcess/Network/webrtc/WebRTCResolver.messages.in:
+ * WebProcess/Network/webrtc/WebRTCSocket.messages.in:
+ * WebProcess/Notifications/WebNotificationManager.messages.in:
+ * WebProcess/Storage/WebSWContextManagerConnection.messages.in:
+ * WebProcess/WebPage/DrawingArea.messages.in:
+ * WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
+ * WebProcess/WebProcess.messages.in:
+ * WebProcess/cocoa/UserMediaCaptureManager.messages.in:
+
2019-11-19 Per Arne Vollan <[email protected]>
[iOS] Fix sysctl-read sandbox violation
Modified: trunk/Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-messages -> WebCookieManager {
+messages -> WebCookieManager NotRefCounted {
void GetHostnamesWithCookies(PAL::SessionID sessionID) -> (Vector<String> hostnames) Async
void DeleteCookiesForHostnames(PAL::SessionID sessionID, Vector<String> hostnames)
void DeleteAllCookies(PAL::SessionID sessionID)
Modified: trunk/Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> LegacyCustomProtocolManager {
+messages -> LegacyCustomProtocolManager NotRefCounted {
DidFailWithError(uint64_t customProtocolID, WebCore::ResourceError error)
DidLoadData(uint64_t customProtocolID, IPC::DataReference data)
DidReceiveResponse(uint64_t customProtocolID, WebCore::ResourceResponse response, uint32_t cacheStoragePolicy)
Modified: trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(INDEXED_DATABASE)
-messages -> WebIDBConnectionToClient {
+messages -> WebIDBConnectionToClient NotRefCounted {
DeleteDatabase(WebCore::IDBRequestData requestData)
OpenDatabase(WebCore::IDBRequestData requestData);
AbortTransaction(WebCore::IDBResourceIdentifier transactionIdentifier);
Modified: trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(CONTENT_EXTENSIONS)
-messages -> NetworkContentRuleListManager {
+messages -> NetworkContentRuleListManager NotRefCounted {
Remove(WebKit::UserContentControllerIdentifier identifier)
AddContentRuleLists(WebKit::UserContentControllerIdentifier identifier, Vector<std::pair<String, WebKit::WebCompiledContentRuleListData>> contentFilters)
RemoveContentRuleList(WebKit::UserContentControllerIdentifier identifier, String name)
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> NetworkSocketChannel {
+messages -> NetworkSocketChannel NotRefCounted {
SendString(String message) -> () Async
SendData(IPC::DataReference data) -> () Async
Close(int32_t code, String reason)
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(SERVICE_WORKER)
-messages -> ServiceWorkerFetchTask {
+messages -> ServiceWorkerFetchTask NotRefCounted {
DidNotHandle()
DidFail(WebCore::ResourceError error)
DidReceiveRedirectResponse(WebCore::ResourceResponse response)
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(SERVICE_WORKER)
-messages -> WebSWServerConnection {
+messages -> WebSWServerConnection NotRefCounted {
# When possible, these messages can be implemented directly by WebCore::SWClientConnection
ScheduleJobInServer(struct WebCore::ServiceWorkerJobData jobData)
FinishFetchingScriptInServer(struct WebCore::ServiceWorkerFetchResult result)
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(SERVICE_WORKER)
-messages -> WebSWServerToContextConnection {
+messages -> WebSWServerToContextConnection NotRefCounted {
# When possible, these messages can be implemented directly by WebCore::SWServerToContextConnection
ScriptContextFailedToStart(Optional<WebCore::ServiceWorkerJobDataIdentifier> jobDataIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, String message);
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(WEB_RTC)
-messages -> NetworkMDNSRegister {
+messages -> NetworkMDNSRegister NotRefCounted {
UnregisterMDNSNames(WebCore::DocumentIdentifier documentIdentifier)
RegisterMDNSName(uint64_t requestIdentifier, WebCore::DocumentIdentifier documentIdentifier, String ipAddress)
}
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if USE(LIBWEBRTC)
-messages -> NetworkRTCMonitor {
+messages -> NetworkRTCMonitor NotRefCounted {
void StartUpdating()
void StopUpdating()
}
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.messages.in (252654 => 252655)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if USE(LIBWEBRTC)
-messages -> NetworkRTCSocket {
+messages -> NetworkRTCSocket NotRefCounted {
void SendTo(IPC::DataReference data, WebKit::RTCNetwork::SocketAddress address, struct WebKit::RTCPacketOptions options)
void Close()
void SetOption(int option, int value)
Modified: trunk/Source/WebKit/PluginProcess/PluginControllerProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/PluginProcess/PluginControllerProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/PluginProcess/PluginControllerProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
-messages -> PluginControllerProxy LegacyReceiver {
+messages -> PluginControllerProxy LegacyReceiver NotRefCounted {
# Sent when the plug-in geometry changes.
GeometryDidChange(WebCore::IntSize pluginSize, WebCore::IntRect clipRect, WebCore::AffineTransform pluginToRootViewTransform, float scaleFactor, WebKit::ShareableBitmap::Handle backingStoreHandle)
Modified: trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in (252654 => 252655)
--- trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
-messages -> PluginProcess LegacyReceiver {
+messages -> PluginProcess LegacyReceiver NotRefCounted {
# Initializes the plug-in process.
InitializePluginProcess(struct WebKit::PluginProcessCreationParameters processCreationParameters)
Modified: trunk/Source/WebKit/Scripts/webkit/messages.py (252654 => 252655)
--- trunk/Source/WebKit/Scripts/webkit/messages.py 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Scripts/webkit/messages.py 2019-11-20 00:32:19 UTC (rev 252655)
@@ -28,6 +28,7 @@
WANTS_CONNECTION_ATTRIBUTE = 'WantsConnection'
LEGACY_RECEIVER_ATTRIBUTE = 'LegacyReceiver'
+NOT_REFCOUNTED_RECEIVER_ATTRIBUTE = 'NotRefCounted'
SYNCHRONOUS_ATTRIBUTE = 'Synchronous'
ASYNC_ATTRIBUTE = 'Async'
@@ -753,6 +754,9 @@
if async_messages:
result.append('void %s::didReceive%sMessage(IPC::Connection& connection, IPC::Decoder& decoder)\n' % (receiver.name, receiver.name if receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE) else ''))
result.append('{\n')
+ if not receiver.has_attribute(NOT_REFCOUNTED_RECEIVER_ATTRIBUTE):
+ result.append(' auto protectedThis = makeRef(*this);\n')
+
result += [async_message_statement(receiver, message) for message in async_messages]
if (receiver.superclass):
result.append(' %s::didReceiveMessage(connection, decoder);\n' % (receiver.superclass))
@@ -766,6 +770,8 @@
result.append('\n')
result.append('void %s::didReceiveSync%sMessage(IPC::Connection& connection, IPC::Decoder& decoder, std::unique_ptr<IPC::Encoder>& replyEncoder)\n' % (receiver.name, receiver.name if receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE) else ''))
result.append('{\n')
+ if not receiver.has_attribute(NOT_REFCOUNTED_RECEIVER_ATTRIBUTE):
+ result.append(' auto protectedThis = makeRef(*this);\n')
result += [sync_message_statement(receiver, message) for message in sync_messages]
result.append(' UNUSED_PARAM(connection);\n')
result.append(' UNUSED_PARAM(decoder);\n')
Modified: trunk/Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.messages.in (252654 => 252655)
--- trunk/Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> RemoteObjectRegistry {
+messages -> RemoteObjectRegistry NotRefCounted {
InvokeMethod(WebKit::RemoteObjectInvocation invocation)
CallReplyBlock(uint64_t replyID, WebKit::UserData blockInvocation);
ReleaseUnusedReplyBlock(uint64_t replyID);
Modified: trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -24,7 +24,7 @@
#if ENABLE(APPLE_PAY)
-messages -> WebPaymentCoordinatorProxy {
+messages -> WebPaymentCoordinatorProxy NotRefCounted {
CanMakePayments() -> (bool result) Synchronous
CanMakePaymentsWithActiveCard(String merchantIdentifier, String domainName) -> (bool canMakePayments) Async
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,6 +20,6 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> AuthenticationManager {
+messages -> AuthenticationManager NotRefCounted {
void CompleteAuthenticationChallenge(uint64_t challengeID, enum:uint8_t WebKit::AuthenticationChallengeDisposition disposition, WebCore::Credential credential);
}
Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.messages.in (252654 => 252655)
--- trunk/Source/WebKit/Shared/AuxiliaryProcess.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> AuxiliaryProcess {
+messages -> AuxiliaryProcess NotRefCounted {
ShutDown()
SetProcessSuppressionEnabled(bool flag)
Modified: trunk/Source/WebKit/Shared/Plugins/NPObjectMessageReceiver.messages.in (252654 => 252655)
--- trunk/Source/WebKit/Shared/Plugins/NPObjectMessageReceiver.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/Shared/Plugins/NPObjectMessageReceiver.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
-messages -> NPObjectMessageReceiver LegacyReceiver {
+messages -> NPObjectMessageReceiver LegacyReceiver NotRefCounted {
Deallocate() -> () Synchronous
HasMethod(WebKit::NPIdentifierData methodName) -> (bool returnValue) Synchronous
Invoke(WebKit::NPIdentifierData methodName, Vector<WebKit::NPVariantData> argumentsData) -> (bool returnValue, WebKit::NPVariantData resultData) Synchronous
Modified: trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -23,7 +23,7 @@
#if ENABLE(MEDIA_STREAM)
-messages -> UserMediaCaptureManagerProxy {
+messages -> UserMediaCaptureManagerProxy NotRefCounted {
CreateMediaSourceForCaptureDeviceWithConstraints(uint64_t id, WebCore::CaptureDevice device, String hashSalt, struct WebCore::MediaConstraints constraints) -> (bool success, String invalidConstraints, WebCore::RealtimeMediaSourceSettings settings) Synchronous
StartProducingData(uint64_t id)
StopProducingData(uint64_t id)
Modified: trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> DrawingAreaProxy {
+messages -> DrawingAreaProxy NotRefCounted {
Update(uint64_t stateID, WebKit::UpdateInfo updateInfo)
DidUpdateBackingStoreState(uint64_t backingStoreStateID, WebKit::UpdateInfo updateInfo, WebKit::LayerTreeContext context)
EnterAcceleratedCompositingMode(uint64_t backingStoreStateID, WebKit::LayerTreeContext context)
Modified: trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> LegacyCustomProtocolManagerProxy {
+messages -> LegacyCustomProtocolManagerProxy NotRefCounted {
StartLoading(uint64_t customProtocolID, WebCore::ResourceRequest request)
StopLoading(uint64_t customProtocolID)
}
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> NetworkProcessProxy LegacyReceiver {
+messages -> NetworkProcessProxy LegacyReceiver NotRefCounted {
DidReceiveAuthenticationChallenge(PAL::SessionID sessionID, WebKit::WebPageProxyIdentifier pageID, Optional<WebCore::SecurityOriginData> topOrigin, WebCore::AuthenticationChallenge challenge, uint64_t challengeID)
DidFetchWebsiteData(uint64_t callbackID, struct WebKit::WebsiteData websiteData)
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> RemoteLayerTreeDrawingAreaProxy : DrawingAreaProxy {
+messages -> RemoteLayerTreeDrawingAreaProxy : DrawingAreaProxy NotRefCounted {
void WillCommitLayerTree(WebKit::TransactionID transactionID)
void CommitLayerTree(WebKit::RemoteLayerTreeTransaction layerTreeTransaction, WebKit::RemoteScrollingCoordinatorTransaction scrollingTreeTransaction)
}
Modified: trunk/Source/WebKit/UIProcess/ViewGestureController.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/ViewGestureController.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/ViewGestureController.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> ViewGestureController {
+messages -> ViewGestureController NotRefCounted {
#if PLATFORM(MAC)
DidCollectGeometryForMagnificationGesture(WebCore::FloatRect visibleContentBounds, bool frameHandlesMagnificationGesture)
DidCollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin, WebCore::FloatRect renderRect, WebCore::FloatRect visibleContentBounds, bool fitEntireRect, double viewportMinimumScale, double viewportMaximumScale)
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -24,7 +24,7 @@
#if ENABLE(WEB_AUTHN)
-messages -> WebAuthenticatorCoordinatorProxy {
+messages -> WebAuthenticatorCoordinatorProxy NotRefCounted {
MakeCredential(WebCore::FrameIdentifier frameID, struct WebCore::SecurityOriginData origin, Vector<uint8_t> hash, struct WebCore::PublicKeyCredentialCreationOptions options) -> (struct WebCore::PublicKeyCredentialData data, struct WebCore::ExceptionData exception) Async
GetAssertion(WebCore::FrameIdentifier frameID, struct WebCore::SecurityOriginData origin, Vector<uint8_t> hash, struct WebCore::PublicKeyCredentialRequestOptions options) -> (struct WebCore::PublicKeyCredentialData data, struct WebCore::ExceptionData exception) Async
Modified: trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -21,7 +21,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#if ENABLE(FULLSCREEN_API)
-messages -> WebFullScreenManagerProxy {
+messages -> WebFullScreenManagerProxy NotRefCounted {
SupportsFullScreen(bool withKeyboard) -> (bool supportsFullScreen) Synchronous
EnterFullScreen()
ExitFullScreen()
Modified: trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> WebPasteboardProxy {
+messages -> WebPasteboardProxy NotRefCounted {
#if PLATFORM(IOS_FAMILY)
WriteURLToPasteboard(struct WebCore::PasteboardURL url, String pasteboardName)
WriteWebContentToPasteboard(struct WebCore::PasteboardWebContent content, String pasteboardName)
Modified: trunk/Source/WebKit/UIProcess/ios/SmartMagnificationController.messages.in (252654 => 252655)
--- trunk/Source/WebKit/UIProcess/ios/SmartMagnificationController.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/UIProcess/ios/SmartMagnificationController.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if PLATFORM(IOS_FAMILY)
-messages -> SmartMagnificationController {
+messages -> SmartMagnificationController NotRefCounted {
DidCollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin, WebCore::FloatRect renderRect, WebCore::FloatRect visibleContentBounds, bool fitEntireRect, double viewportMinimumScale, double viewportMaximumScale)
Magnify(WebCore::FloatPoint origin, WebCore::FloatRect targetRect, WebCore::FloatRect visibleContentRect, double viewportMinimumScale, double viewportMaximumScale)
ScrollToRect(WebCore::FloatPoint origin, WebCore::FloatRect targetRect)
Modified: trunk/Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -24,7 +24,7 @@
#if ENABLE(APPLE_PAY)
-messages -> WebPaymentCoordinator {
+messages -> WebPaymentCoordinator NotRefCounted {
ValidateMerchant(String validationURLString)
DidAuthorizePayment(WebCore::Payment payment)
Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> WebAutomationSessionProxy {
+messages -> WebAutomationSessionProxy NotRefCounted {
EvaluateJavaScriptFunction(WebCore::PageIdentifier pageID, Optional<WebCore::FrameIdentifier> frameID, String function, Vector<String> arguments, bool expectsImplicitCallbackArgument, int callbackTimeout, uint64_t callbackID)
ResolveChildFrameWithOrdinal(WebCore::PageIdentifier pageID, Optional<WebCore::FrameIdentifier> frameID, uint32_t ordinal) -> (Optional<String> errorType, Optional<WebCore::FrameIdentifier> frameID) Async
Modified: trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> WebGeolocationManager {
+messages -> WebGeolocationManager NotRefCounted {
DidChangePosition(WebCore::GeolocationPositionData position);
DidFailToDeterminePosition(String errorMessage);
#if PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(WEB_RTC)
-messages -> WebMDNSRegister {
+messages -> WebMDNSRegister NotRefCounted {
void FinishedRegisteringMDNSName(uint64_t identifier, WebCore::LibWebRTCProvider::MDNSNameOrError result)
}
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if USE(LIBWEBRTC)
-messages -> WebRTCMonitor {
+messages -> WebRTCMonitor NotRefCounted {
void NetworksChanged(Vector<WebKit::RTCNetwork> networks, WebKit::RTCNetwork::IPAddress defaultIPV4Address, WebKit::RTCNetwork::IPAddress defaultIPV6Address)
}
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if USE(LIBWEBRTC)
-messages -> WebRTCResolver {
+messages -> WebRTCResolver NotRefCounted {
void SetResolvedAddress(Vector<WebKit::RTCNetwork::IPAddress> addresses)
void ResolvedAddressError(int error)
}
Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if USE(LIBWEBRTC)
-messages -> WebRTCSocket {
+messages -> WebRTCSocket NotRefCounted {
SignalReadPacket(IPC::DataReference data, WebKit::RTCNetwork::IPAddress address, uint16_t port, int64_t timestamp)
SignalSentPacket(int packetSize, int64_t timestamp)
SignalAddressReady(WebKit::RTCNetwork::SocketAddress address)
Modified: trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> WebNotificationManager {
+messages -> WebNotificationManager NotRefCounted {
DidShowNotification(uint64_t notificationID);
DidClickNotification(uint64_t notificationID);
DidCloseNotifications(Vector<uint64_t> notificationIDs);
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -22,7 +22,7 @@
#if ENABLE(SERVICE_WORKER)
-messages -> WebSWContextManagerConnection {
+messages -> WebSWContextManagerConnection NotRefCounted {
InstallServiceWorker(struct WebCore::ServiceWorkerContextData contextData, String userAgent)
StartFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options, IPC::FormDataReference requestBody, String referrer)
CancelFetch(WebCore::SWServerConnectionIdentifier serverConnectionIdentifier, WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, WebCore::FetchIdentifier fetchIdentifier)
Modified: trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> DrawingArea {
+messages -> DrawingArea NotRefCounted {
UpdateBackingStoreState(uint64_t backingStoreStateID, bool respondImmediately, float deviceScaleFactor, WebCore::IntSize size, WebCore::IntSize scrollOffset)
DidUpdate()
Modified: trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> ViewGestureGeometryCollector {
+messages -> ViewGestureGeometryCollector NotRefCounted {
#if PLATFORM(COCOA)
CollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin)
#endif
Modified: trunk/Source/WebKit/WebProcess/WebProcess.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/WebProcess.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/WebProcess.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -20,7 +20,7 @@
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-messages -> WebProcess LegacyReceiver {
+messages -> WebProcess LegacyReceiver NotRefCounted {
InitializeWebProcess(struct WebKit::WebProcessCreationParameters processCreationParameters)
SetWebsiteDataStoreParameters(struct WebKit::WebProcessDataStoreParameters parameters)
Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.messages.in (252654 => 252655)
--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.messages.in 2019-11-20 00:16:37 UTC (rev 252654)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.messages.in 2019-11-20 00:32:19 UTC (rev 252655)
@@ -23,7 +23,7 @@
#if ENABLE(MEDIA_STREAM)
-messages -> UserMediaCaptureManager {
+messages -> UserMediaCaptureManager NotRefCounted {
CaptureFailed(uint64_t id)
SourceStopped(uint64_t id)
SourceMutedChanged(uint64_t id, bool muted)
