Title: [253220] trunk/Websites/perf.webkit.org
- Revision
- 253220
- Author
- dewei_...@apple.com
- Date
- 2019-12-06 14:49:02 -0800 (Fri, 06 Dec 2019)
Log Message
Custom analysis task page should allow schedule any triggerable accepted tests.
https://bugs.webkit.org/show_bug.cgi?id=204925
Reviewed by Ryosuke Niwa.
Fix a bug that subtest will not show on custom analysis task page if both itself and parent test are
accepted by triggerable.
Order test list in alphabetical order.
* public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (253219 => 253220)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-12-06 22:45:38 UTC (rev 253219)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-12-06 22:49:02 UTC (rev 253220)
@@ -1,3 +1,17 @@
+2019-12-05 Dewei Zhu <dewei_...@apple.com>
+
+ Custom analysis task page should allow schedule any triggerable accepted tests.
+ https://bugs.webkit.org/show_bug.cgi?id=204925
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix a bug that subtest will not show on custom analysis task page if both itself and parent test are
+ accepted by triggerable.
+ Order test list in alphabetical order.
+
+ * public/v3/components/custom-analysis-task-configurator.js:
+ (CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests):
+
2019-10-28 Dewei Zhu <dewei_...@apple.com>
Fix a bug that cannot unhide a platform.
Modified: trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js (253219 => 253220)
--- trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js 2019-12-06 22:45:38 UTC (rev 253219)
+++ trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js 2019-12-06 22:49:02 UTC (rev 253220)
@@ -224,8 +224,11 @@
for (const test of triggerable.acceptedTests())
acceptedTests.add(test);
}
-
- let tests = Test.all().filter((test) => acceptedTests.has(test) && (!test.parentTest() || !acceptedTests.has(test.parentTest())));
+ const tests = [...acceptedTests].sort((testA, testB) => {
+ if (testA.fullName() == testB.fullName())
+ return 0;
+ return testA.fullName() < testB.fullName() ? -1 : 1;
+ });
return this._renderRadioButtonList(this.content('test-list'), 'test', tests, this.selectTests.bind(this), (test) => test.fullName());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
