Title: [254549] trunk/Source/_javascript_Core
Revision
254549
Author
keith_mil...@apple.com
Date
2020-01-14 17:45:15 -0800 (Tue, 14 Jan 2020)

Log Message

Fix scanSideState assertion
https://bugs.webkit.org/show_bug.cgi?id=206257

Reviewed by Yusuke Suzuki.

* runtime/VM.cpp:
(JSC::VM::scanSideState const):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (254548 => 254549)


--- trunk/Source/_javascript_Core/ChangeLog	2020-01-15 01:39:11 UTC (rev 254548)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-15 01:45:15 UTC (rev 254549)
@@ -1,3 +1,13 @@
+2020-01-14  Keith Miller  <keith_mil...@apple.com>
+
+        Fix scanSideState assertion
+        https://bugs.webkit.org/show_bug.cgi?id=206257
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/VM.cpp:
+        (JSC::VM::scanSideState const):
+
 2020-01-14  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: crash in DumpRenderTree at com.apple._javascript_Core: WTF::RefCountedBase::hasOneRef const

Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (254548 => 254549)


--- trunk/Source/_javascript_Core/runtime/VM.cpp	2020-01-15 01:39:11 UTC (rev 254548)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2020-01-15 01:45:15 UTC (rev 254549)
@@ -1066,7 +1066,7 @@
 
 void VM::scanSideState(ConservativeRoots& roots) const
 {
-    ASSERT(heap.mutatorState() != MutatorState::Running);
+    ASSERT(heap.worldIsStopped());
     for (const auto& iter : m_checkpointSideState) {
         static_assert(sizeof(iter.value->tmps) / sizeof(JSValue) == maxNumCheckpointTmps);
         roots.add(iter.value->tmps, iter.value->tmps + maxNumCheckpointTmps);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to